Fix unit test mocks

Author: carlcsaposs-canonical

tests/unit/conftest.py

@@ -1,9 +1,12 @@
 # Copyright 2023 Canonical Ltd.
 # See LICENSE file for licensing details.
-
+import pathlib
+import platform
 
 import ops
 import pytest
+import tomli
+
 from charms.tempo_coordinator_k8s.v0.charm_tracing import charm_tracing_disabled
 
 import snap
@@ -29,6 +32,28 @@ def disable_tenacity_retry(monkeypatch):
         monkeypatch.setattr(f"tenacity.{retry_class}.__call__", lambda *args, **kwargs: False)
 
 
+class _MockRefresh:
+    in_progress = False
+    next_unit_allowed_to_refresh = True
+    workload_allowed_to_start = True
+    app_status_higher_priority = None
+    unit_status_higher_priority = None
+
+    def __init__(self, _, /):
+        pass
+
+    def update_snap_revision(self):
+        pass
+
+    @property
+    def pinned_snap_revision(self):
+        with pathlib.Path("refresh_versions.toml").open("rb") as file:
+            return tomli.load(file)["snap"]["revisions"][platform.machine()]
+
+    def unit_status_lower_priority(self, *, workload_is_running=True):
+        return None
+
+
 @pytest.fixture(autouse=True)
 def patch(monkeypatch):
     monkeypatch.setattr(
@@ -41,9 +66,8 @@ def patch(monkeypatch):
         "mysql_shell.Shell.get_mysql_router_user_for_unit", lambda *args, **kwargs: None
     )
     monkeypatch.setattr("mysql_shell.Shell.is_router_in_cluster_set", lambda *args, **kwargs: True)
-    monkeypatch.setattr("upgrade.Upgrade.in_progress", False)
-    monkeypatch.setattr("upgrade.Upgrade.versions_set", True)
-    monkeypatch.setattr("upgrade.Upgrade.is_compatible", True)
+    monkeypatch.setattr("charm_refresh.Machines", _MockRefresh)
+    monkeypatch.setattr("relations.database_requires.RelationEndpoint.does_relation_exist", lambda *args, **kwargs: True)
 
 
 # flake8: noqa: C901
@@ -102,6 +126,7 @@ def restart(self, services: list[str] = []):
         "snap.Snap._run_command",
         lambda *args, **kwargs: "null",  # Use "null" for `json.loads()`
     )
+    monkeypatch.setattr("snap.Snap.install", lambda *args, **kwargs: None)
     monkeypatch.setattr("snap._Path.read_text", lambda *args, **kwargs: "")
     monkeypatch.setattr("snap._Path.write_text", lambda *args, **kwargs: None)
     monkeypatch.setattr("snap._Path.unlink", lambda *args, **kwargs: None)

tests/unit/scenario_/database_relations/test_database_relations.py

@@ -23,7 +23,7 @@ def output_states(*, relations: list[scenario.Relation]) -> typing.Iterable[scen
     """
     context = scenario.Context(charm.MachineSubordinateRouterCharm)
     input_state = scenario.State(
-        relations=[*relations, scenario.PeerRelation(endpoint="upgrade-version-a")],
+        relations=[*relations, scenario.PeerRelation(endpoint="refresh-v-three")],
         leader=True,
     )
     events = []

tests/unit/scenario_/database_relations/test_database_relations_breaking.py

@@ -17,7 +17,7 @@ def output_state(
 ) -> scenario.State:
     context = scenario.Context(charm.MachineSubordinateRouterCharm)
     input_state = scenario.State(
-        relations=[*relations, scenario.PeerRelation(endpoint="upgrade-version-a")],
+        relations=[*relations, scenario.PeerRelation(endpoint="refresh-v-three")],
         secrets=secrets,
         leader=True,
     )

tests/unit/scenario_/test_start.py

@@ -13,7 +13,7 @@ def test_start_sets_status_if_no_relations(leader):
     context = scenario.Context(charm.MachineSubordinateRouterCharm)
     input_state = scenario.State(
         leader=leader,
-        relations=[scenario.PeerRelation(endpoint="upgrade-version-a")],
+        relations=[scenario.PeerRelation(endpoint="refresh-v-three")],
     )
     output_state = context.run("start", input_state)
     if leader: