Skip to content

Commit be36621

Browse files
Revert changes to Allure in #250 (#259)
Reverts part of #250 An Allure Report can only be generated for one of the test suite combinations (otherwise results with identical test case IDs will override each other. Any parametrization that pytest is not aware of [because it was done in spread—i.e. juju version, ubuntu base] will result in duplicate test case IDs) Removing the 20.04 base does not change this—we are only able to generate an Allure Report for one of the Juju versions we test with TL;DR the Allure Report should only use tests from a single spread variant. The variant naming was not changed, so the Allure Report config should not have been changed
1 parent 3ced59f commit be36621

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

.github/workflows/integration_test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ jobs:
128128
# Only upload results from one spread system & one spread variant
129129
# Allure can only process one result per pytest test ID. If parameterization is done via
130130
# spread instead of pytest, there will be overlapping pytest test IDs.
131-
if: ${{ (success() || (failure() && steps.spread.outcome == 'failure')) && startsWith(matrix.job.spread_job, 'github-ci:ubuntu-24.04:') && github.event_name == 'schedule' && github.run_attempt == '1' }}
131+
if: ${{ (success() || (failure() && steps.spread.outcome == 'failure')) && startsWith(matrix.job.spread_job, 'github-ci:ubuntu-24.04:') && endsWith(matrix.job.spread_job, ':juju36_ubuntu22') && github.event_name == 'schedule' && github.run_attempt == '1' }}
132132
uses: actions/upload-artifact@v4
133133
with:
134134
name: allure-results-integration-test-${{ matrix.job.name_in_artifact }}

tests/spread/test_data_integrator.py/task.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,3 @@ execute: |
55
tox run -e integration -- "tests/integration/$TEST_MODULE" --model testing --alluredir="$SPREAD_TASK/allure-results"
66
artifacts:
77
- allure-results
8-
variants:
9-
- -juju36_ubuntu20
10-
- -juju29_ubuntu20

tests/spread/test_hacluster.py/task.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,3 @@ execute: |
55
tox run -e integration -- "tests/integration/$TEST_MODULE" --model testing --alluredir="$SPREAD_TASK/allure-results"
66
artifacts:
77
- allure-results
8-
variants:
9-
- -juju36_ubuntu20
10-
- -juju29_ubuntu20

0 commit comments

Comments
 (0)