uncaught-except-upgrade-charm-event

Author: carlcsaposs-canonical

.github/workflows/ci.yaml

@@ -29,7 +29,7 @@ jobs:
       - build
     uses: canonical/data-platform-workflows/.github/workflows/[email protected]
     with:
-      channel: dpe/edge/test-refresh-v3-uncaught-before-snap-refresh
+      channel: dpe/edge/test-refresh-v3-uncaught-except-upgrade-charm-event
       artifact-prefix: ${{ needs.build.outputs.artifact-prefix }}
       create-git-tags: false
     secrets:

refresh_versions.toml

@@ -4,7 +4,7 @@ charm_major = 1
 workload = "8.0.41"
 
 # autogenerated
-charm = "8.0/1.5.0"
+charm = "8.0/1.6.0"
 
 [snap]
 name = "charmed-mysql"

src/charm.py

@@ -18,6 +18,7 @@
 import socket
 import typing
 
+import charm_ as charm
 import charm_refresh
 import ops.log
 import tenacity
@@ -44,7 +45,6 @@ class _MachinesRouterRefresh(abstract_charm.RouterRefresh, charm_refresh.CharmSp
     def refresh_snap(
         self, *, snap_name: str, snap_revision: str, refresh: charm_refresh.Machines
     ) -> None:
-        raise Exception
         # TODO: issue on relation-broken event since event not passed? mitigated by regular event handler?
         self._charm.get_workload(event=None, refresh=refresh).refresh(
             event=None,
@@ -109,7 +109,8 @@ def __init__(self, *args) -> None:
             self._reconcile_allowed = False
         else:
             self._reconcile_allowed = True
-        raise Exception
+        if not isinstance(charm.event, charm.UpgradeCharmEvent):
+            raise Exception
 
     @property
     def _subordinate_relation_endpoint_names(self) -> typing.Optional[typing.Iterable[str]]: