Skip to content

upgrade_unit does match signature of abstract method #139

@carlcsaposs-canonical

Description

@carlcsaposs-canonical

Mismatch between
upgrade_unit call in abstract_charm.py (type hinting is for abstract upgrade.py)

self._upgrade.upgrade_unit(
event=event,
workload_=workload_,
tls=self._tls_certificate_saved,
exporter_config=self._cos_exporter_config(event),
)

upgrade.py abstract upgrade_unit

@abc.abstractmethod
def upgrade_unit(self, *, workload_: workload.Workload, tls: bool) -> None:
"""Upgrade this unit.
Only applies to machine charm
"""

machine_upgrade.py upgrade_unit

def upgrade_unit(
self,
*,
event,
workload_: workload.Workload,
tls: bool,
exporter_config: "relations.cos.ExporterConfig",
) -> None:

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions