Skip to content

Commit 4c2211c

Browse files
DPE-7726: Avoid unnecessary Patroni reloads
The list of IPs were randomly sorted causing unnecessary Partroni configuration re-generation with following Patroni restart/reload.
1 parent db93686 commit 4c2211c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ def render_patroni_yml_file(
744744
partner_addrs=self.charm.async_replication.get_partner_addresses()
745745
if not no_peers
746746
else [],
747-
peers_ips=self.peers_ips if not no_peers else set(),
747+
peers_ips=sorted(self.peers_ips) if not no_peers else set(),
748748
pgbackrest_configuration_file=PGBACKREST_CONFIGURATION_FILE,
749749
scope=self.cluster_name,
750750
self_ip=self.unit_ip,

src/relations/async_replication.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,9 @@ def get_partner_addresses(self) -> list[str]:
265265
or self.charm.unit_peer_data.get("unit-promoted-cluster-counter")
266266
== self._get_highest_promoted_cluster_counter_value()
267267
) and (peer_members := self.charm._peer_members_ips):
268-
logger.debug(f"Partner addresses: {peer_members}")
269-
return list(peer_members)
268+
sorted_partners = sorted(peer_members)
269+
logger.debug(f"Partner addresses: {sorted_partners}")
270+
return list(sorted_partners)
270271

271272
logger.debug("Partner addresses: []")
272273
return []

0 commit comments

Comments
 (0)