Skip to content

Commit 66c6665

Browse files
committed
refactor(async-replication): drop the labelless-design comment block
The no-label invariant and the failure history it explained belong to the commit messages and the PR description (DPE-10203); restating them at the module head duplicates that record where it goes stale as the code evolves. The code itself — no label constant defined, secret access strictly by id — already expresses the invariant. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
1 parent 9bcbf47 commit 66c6665

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

src/relations/async_replication.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,6 @@
6969

7070

7171
READ_ONLY_MODE_BLOCKING_MESSAGE = "Standalone read-only cluster"
72-
# Neither side of the async-replication relation attaches any label to the shared
73-
# cluster-credentials secret (DPE-10203): the owner creates it labelless and references it by the
74-
# id persisted in app peer data (``_get_secret``); the consumer references it purely by the id
75-
# published in the relation databag (``_update_internal_secret``). Juju reserves labels even
76-
# after the secret they pointed at is gone — a stale consumer alias deadlocks a later
77-
# owner-create ("secret with label already exists" while the label is unreadable), and a stale
78-
# owner label makes a refreshed owner mint a second secret whose id switch wedges any consumer
79-
# still running label-attaching code. The legacy labels "async-replication-secret" and
80-
# "async-replication-secret-offer" are intentionally not defined anywhere: this charm must
81-
# never attach either again.
8272

8373

8474
def _same_secret_id(a: str | None, b: str | None) -> bool:

0 commit comments

Comments
 (0)