[DPE-4068] Finish test migration from unittest to pytest + enable/disable secrets in every test (#451)

* first effort

* finish migration to pytest

* remove print statement

* add conftest with has_secrets fixture

* fix commit email

* fix lint

* fix copyright year

* refactor asserts

Author: Lucas Gameiro

tests/unit/conftest.py

@@ -0,0 +1,14 @@
+#!/usr/bin/env python3
+# Copyright 2024 Canonical Ltd.
+# See LICENSE file for licensing details.
+from unittest.mock import PropertyMock
+
+import pytest
+
+
+# This causes every test defined in this file to run 2 times, each with
+# charm.JujuVersion.has_secrets set as True or as False
+@pytest.fixture(params=[True, False], autouse=True)
+def _has_secrets(request, monkeypatch):
+    monkeypatch.setattr("charm.JujuVersion.has_secrets", PropertyMock(return_value=request.param))
+    return request.param

tests/unit/test_backups.py

@@ -48,14 +48,6 @@ def harness():
     harness.cleanup()
 
 
-# This causes every test defined in this file to run 2 times, each with
-# charm.JujuVersion.has_secrets set as True or as False
-@pytest.fixture(params=[True, False], autouse=True)
-def _has_secrets(request, monkeypatch):
-    monkeypatch.setattr("charm.JujuVersion.has_secrets", PropertyMock(return_value=request.param))
-    return request.param
-
-
 @patch_network_get(private_address="1.1.1.1")
 def test_on_install(harness):
     with patch("charm.subprocess.check_call") as _check_call, patch(