Skip to content

Commit 8bc5a19

Browse files
[python ci] Update Python CI dependencies (major) (#335)
* [python ci] Update Python CI dependencies * Linting --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <[email protected]>
1 parent 9b9692b commit 8bc5a19

File tree

5 files changed

+55
-47
lines changed

5 files changed

+55
-47
lines changed

poetry.lock

Lines changed: 29 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jsonschema = "*"
4242
optional = true
4343

4444
[tool.poetry.group.format.dependencies]
45-
black = "^23.12.1"
45+
black = "^24.2.0"
4646
ruff = "^0.3.1"
4747

4848
[tool.poetry.group.lint]
@@ -56,7 +56,7 @@ optional = true
5656

5757
[tool.poetry.group.unit.dependencies]
5858
coverage = {extras = ["toml"], version = "^7.4.3"}
59-
pytest = "^7.4.4"
59+
pytest = "^8.0.2"
6060
pytest-asyncio = "*"
6161
parameterized = "^0.9.0"
6262
jsonschema = "^4.21.1"
@@ -66,7 +66,7 @@ jinja2 = "^3.1.3"
6666
optional = true
6767

6868
[tool.poetry.group.integration.dependencies]
69-
pytest = "^7.4.4"
69+
pytest = "^8.0.2"
7070
pytest-github-secrets = {git = "https://github.com/canonical/data-platform-workflows", tag = "v12.6.2", subdirectory = "python/pytest_plugins/github_secrets"}
7171
pytest-operator = "^0.34.0"
7272
pytest-operator-cache = {git = "https://github.com/canonical/data-platform-workflows", tag = "v12.6.2", subdirectory = "python/pytest_plugins/pytest_operator_cache"}

src/backups.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -870,9 +870,9 @@ def _retrieve_s3_parameters(self) -> Tuple[Dict, List[str]]:
870870
# Clean up extra slash symbols to avoid issues on 3rd-party storages
871871
# like Ceph Object Gateway (radosgw).
872872
s3_parameters["endpoint"] = s3_parameters["endpoint"].rstrip("/")
873-
s3_parameters[
874-
"path"
875-
] = f'/{s3_parameters["path"].strip("/")}' # The slash in the beginning is required by pgBackRest.
873+
s3_parameters["path"] = (
874+
f'/{s3_parameters["path"].strip("/")}' # The slash in the beginning is required by pgBackRest.
875+
)
876876
s3_parameters["bucket"] = s3_parameters["bucket"].strip("/")
877877

878878
return s3_parameters, []

tests/unit/test_charm.py

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1990,10 +1990,14 @@ def test_handle_postgresql_restart_need(
19901990

19911991
self.charm._handle_postgresql_restart_need(values[0])
19921992
_reload_patroni_configuration.assert_called_once()
1993-
self.assertIn(
1994-
"tls", self.harness.get_relation_data(self.rel_id, self.charm.unit)
1995-
) if values[0] else self.assertNotIn(
1996-
"tls", self.harness.get_relation_data(self.rel_id, self.charm.unit)
1993+
(
1994+
self.assertIn(
1995+
"tls", self.harness.get_relation_data(self.rel_id, self.charm.unit)
1996+
)
1997+
if values[0]
1998+
else self.assertNotIn(
1999+
"tls", self.harness.get_relation_data(self.rel_id, self.charm.unit)
2000+
)
19972001
)
19982002
if (values[1] != values[2]) or values[3]:
19992003
self.assertNotIn(
@@ -2002,12 +2006,16 @@ def test_handle_postgresql_restart_need(
20022006
)
20032007
_restart.assert_called_once()
20042008
else:
2005-
self.assertIn(
2006-
"postgresql_restarted",
2007-
self.harness.get_relation_data(self.rel_id, self.charm.unit),
2008-
) if values[4] else self.assertNotIn(
2009-
"postgresql_restarted",
2010-
self.harness.get_relation_data(self.rel_id, self.charm.unit),
2009+
(
2010+
self.assertIn(
2011+
"postgresql_restarted",
2012+
self.harness.get_relation_data(self.rel_id, self.charm.unit),
2013+
)
2014+
if values[4]
2015+
else self.assertNotIn(
2016+
"postgresql_restarted",
2017+
self.harness.get_relation_data(self.rel_id, self.charm.unit),
2018+
)
20112019
)
20122020
_restart.assert_not_called()
20132021

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ commands_pre =
4040
poetry install --only format --no-root
4141
commands =
4242
poetry lock --no-update
43-
poetry run ruff --fix {[vars]all_path}
43+
poetry run ruff check --fix {[vars]all_path}
4444
poetry run black {[vars]all_path}
4545

4646
[testenv:lint]
@@ -53,7 +53,7 @@ commands_pre =
5353
commands =
5454
poetry check --lock
5555
poetry run codespell {[vars]all_path}
56-
poetry run ruff {[vars]all_path}
56+
poetry run ruff check {[vars]all_path}
5757
poetry run black --check --diff {[vars]all_path}
5858
find {[vars]all_path} -type f \( -name "*.sh" -o -name "*.bash" \) -exec poetry run shellcheck --color=always \{\} +
5959

0 commit comments

Comments
 (0)