Workaround Patroni restart_pending flacking flag

Author: taurus-forever

src/cluster.py

@@ -446,18 +446,27 @@ def is_restart_pending(self) -> bool:
         # The current Patroni 3.2.2 has wired behaviour: it temporary flag pending_restart=True
         # on any changes to REST API, which is gone within a second but long enough to be
         # cougth by charm. Sleep 2 seconds as a protection here until Patroni 3.3.0 upgrade
-        sleep(2)
+        pending_restart = self._get_patroni_restart_pending()
+        if pending_restart:
+            # The current Patroni 3.2.2 has wired behaviour: it temporary flag pending_restart=True
+            # on any changes to REST API, which is gone within a second but long enough to be
+            # cougth by charm. Sleep 2 seconds as a protection here until Patroni 3.3.0 upgrade.
+            # Repeat the request to make sure pending_restart flag is still here
+            sleep(2)
+            pending_restart = self._get_patroni_restart_pending()
+
+        return pending_restart
+
+    def _get_patroni_restart_pending(self) -> bool:
+        """Returns whether the Patroni flag pending_restart on REST API."""
         r = requests.get(
             f"{self._patroni_url}/patroni",
             verify=self.verify,
             timeout=API_REQUEST_TIMEOUT,
             auth=self._patroni_auth,
         )
-        try:
-            pending_restart = r.json()["pending_restart"]
-        except KeyError:
-            pending_restart = False
-            pass
+
+        pending_restart = r.json().get("pending_restart", False)
         logger.debug(
             f"API is_restart_pending ({pending_restart}): %s (%s)",
             r,