handling different versions of Postgres of unit

Author: BalabaDmitri

src/charm.py

@@ -468,10 +468,6 @@ def _on_peer_relation_changed(self, event: HookEvent):
         if self.unit.is_leader() and not self._reconfigure_cluster(event):
             event.defer()
             return
-        #
-        # if not self._validate_database_version(self._patroni.get_postgresql_version()):
-        #     self.unit.status = BlockedStatus(DIFFERENT_VERSIONS_PSQL_BLOCKING_MESSAGE)
-        #     return
 
         if self._update_member_ip():
             return
@@ -526,6 +522,8 @@ def _on_peer_relation_changed(self, event: HookEvent):
 
         self._update_new_unit_status()
 
+        self._validate_database_version()
+
     # Split off into separate function, because of complexity _on_peer_relation_changed
     def _start_stop_pgbackrest_service(self, event: HookEvent) -> None:
         # Start or stop the pgBackRest TLS server service when TLS certificate change.
@@ -1584,15 +1582,17 @@ def client_relations(self) -> List[Relation]:
                 relations.append(relation)
         return relations
 
-    def _validate_database_version(self, version: str) -> bool:
+    def _validate_database_version(self):
         """Checking that only one version of Postgres is used."""
         peer_db_version = self.app_peer_data.get("database-version")
 
         if self.unit.is_leader() and peer_db_version is None:
-            self.app_peer_data.update({"database-version": version})
-            return True
+            self.app_peer_data.update({"database-version": self._patroni.get_postgresql_version()})
+            return
 
-        return peer_db_version == self._patroni.get_postgresql_version()
+        if peer_db_version != self._patroni.get_postgresql_version():
+            self.unit.status = BlockedStatus(DIFFERENT_VERSIONS_PSQL_BLOCKING_MESSAGE)
+        return
 
 
 if __name__ == "__main__":