Update Temporal SDK version to 1.18.1 #30
Conversation
|
I tested the changes with one of our workflows which uses Temporal schedules and it was successful. Could you please review since this is blocking us? |
shayancanonical
left a comment
shayancanonical
left a comment
There was a problem hiding this comment.
lgtm, the only code changes i see are the bump of requirements
| python = "^3.9" | ||
| macaroonbakery = "^1.3.1" | ||
| temporalio = "^1.8.0" | ||
| temporalio = "^1.18.1" |
There was a problem hiding this comment.
Please bump the version of the lib as well, as that is what gets published to PyPI. We usually have it in lockstep with the upstream version, so you should set it to 1.18.0.
There was a problem hiding this comment.
I updated the version, thank you
| [tool.poetry] | ||
| name = "temporal-lib-py" | ||
| version = "1.8.4" | ||
| version = "1.18.0" |
There was a problem hiding this comment.
if we're going to keep this lib's version step wise with temporalio in the lib, should this be 1.18.1? this way, we can update the lib for every patch update of temporalio - to avoid any ambiguity of what is included
There was a problem hiding this comment.
We can, but then we might need to make it 1.18.1.0, allowing us to increment the lib version in instances where the SDK version remains the same.
There was a problem hiding this comment.
I think it make sense to keep it 1.18.0 as @kelkawi-a said, it will allow us to patch things since major parts of the SDK version matter most.
There was a problem hiding this comment.
@shayancanonical @kelkawi-a What it the final decision on the version? :)
3 participants
Description
Temporal Python SDK implemented getting last execution result for schedules and released them.
Since we are heavily using Temporal schedules for syncing data between systems, ability to get the last execution result is quite useful for us.
This PR updates the SDK version to the latest version.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers