feat(ubuntu_service): Add generics for parameters (#338)

feat(ubuntu_service): Add parameter generics

Author: spydon

packages/ubuntu_service/lib/src/ubuntu_service.dart

@@ -14,13 +14,13 @@ T? tryGetService<T extends Object>({String? id}) {
 }
 
 /// Locates and invokes an injected service factory.
-T createService<T extends Object>(dynamic param, {String? id}) {
+T createService<T extends Object, P extends Object>(P param, {String? id}) {
   return _locator<T>(param1: param, instanceName: id);
 }
 
 /// Locates and invokes an injected service factory or returns null if not found.
-T? tryCreateService<T extends Object>(dynamic param, {String? id}) {
-  return hasService<T>(id: id) ? createService<T>(param, id: id) : null;
+T? tryCreateService<T extends Object, P extends Object>(P param, {String? id}) {
+  return hasService<T>(id: id) ? createService<T, P>(param, id: id) : null;
 }
 
 /// Returns whether a service is registered with the locator.
@@ -72,23 +72,23 @@ void tryRegisterServiceInstance<T extends Object>(T service, {String? id}) {
 }
 
 /// Registers a service factory with the locator.
-void registerServiceFactory<T extends Object>(
-  T Function(dynamic param) create, {
+void registerServiceFactory<T extends Object, P extends Object>(
+  T Function(P param) create, {
   String? id,
 }) {
-  _locator.registerFactoryParam<T, Object?, Object?>(
+  _locator.registerFactoryParam<T, P, Object?>(
     (param, _) => create(param),
     instanceName: id,
   );
 }
 
 /// Registers a service factory with the locator but only if not already registered.
-void tryRegisterServiceFactory<T extends Object>(
-  T Function(dynamic param) create, {
+void tryRegisterServiceFactory<T extends Object, P extends Object>(
+  T Function(P param) create, {
   String? id,
 }) {
   if (!hasService<T>(id: id)) {
-    registerServiceFactory<T>(create, id: id);
+    registerServiceFactory<T, P>(create, id: id);
   }
 }
 

packages/ubuntu_service/test/ubuntu_service_test.dart

@@ -110,17 +110,15 @@ void main() {
   });
 
   test('service factory', () {
-    final s0 = tryCreateService<ServiceParam>('p0');
+    final s0 = tryCreateService<ServiceParam, String>('p0');
     expect(s0, isNull);
 
-    registerServiceFactory<ServiceParam>(
-      (dynamic param) => ServiceParam(param as String),
-    );
+    registerServiceFactory<ServiceParam, String>(ServiceParam.new);
 
-    final s1 = createService<ServiceParam>('p1');
+    final s1 = createService<ServiceParam, String>('p1');
     expect(s1, isA<ServiceParam>().having((s) => s.param, 'param', 'p1'));
 
-    final s2 = createService<ServiceParam>('p2');
+    final s2 = createService<ServiceParam, String>('p2');
     expect(s2, isA<ServiceParam>().having((s) => s.param, 'param', 'p2'));
   });
 
@@ -152,20 +150,18 @@ void main() {
   test('try factory', () {
     expect(hasService<Service>(), isFalse);
 
-    tryRegisterServiceFactory<ServiceParam>(
-      (dynamic param) => ServiceParam(param as String),
-    );
+    tryRegisterServiceFactory<ServiceParam, String>(ServiceParam.new);
     expect(hasService<ServiceParam>(), isTrue);
 
-    final s1 = createService<ServiceParam>('p1');
+    final s1 = createService<ServiceParam, String>('p1');
     expect(s1, isA<ServiceParam>().having((s) => s.param, 'param', 'p1'));
 
     // noop
-    tryRegisterServiceFactory<ServiceParam>(
-      (dynamic param) => ServiceParam('${param}2'),
+    tryRegisterServiceFactory<ServiceParam, String>(
+      (param) => ServiceParam('${param}2'),
     );
 
-    final s2 = createService<ServiceParam>('p2');
+    final s2 = createService<ServiceParam, String>('p2');
     expect(s2, isA<ServiceParam>().having((s) => s.param, 'param', 'p2'));
   });
 }