From 245f339336610b03b8911bbe2828d9dab787951c Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 13:33:19 +0200 Subject: [PATCH 01/12] fix: Preserve trailing commas --- packages/ubuntu_lints/lib/analysis_options.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index b806c235..2710f84f 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -11,6 +11,9 @@ analyzer: strict-casts: true strict-raw-types: true +formatter: + trailing_commas: preserve + linter: rules: - always_declare_return_types From 8c9745b8cd44fb8d1e2b2bd476e78a5f4c1c43a8 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 13:42:44 +0200 Subject: [PATCH 02/12] Remove warning temporarily --- packages/ubuntu_lints/lib/analysis_options.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index 2710f84f..f75f1c01 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -11,6 +11,10 @@ analyzer: strict-casts: true strict-raw-types: true + warnings: + # TODO: Remove when SDK is bumped to ^3.8.0 + unsupported_option_without_values: ignore + formatter: trailing_commas: preserve From 2c4b4e1b6daa7bb51ddcd9e77cf1a205d00c1f2b Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 13:49:27 +0200 Subject: [PATCH 03/12] warnings -> errors --- packages/ubuntu_lints/lib/analysis_options.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index f75f1c01..07bea3e1 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -11,7 +11,7 @@ analyzer: strict-casts: true strict-raw-types: true - warnings: + errors: # TODO: Remove when SDK is bumped to ^3.8.0 unsupported_option_without_values: ignore From 85230c8a7302f7f92462d998d8d9836e8a47693a Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 14:21:26 +0200 Subject: [PATCH 04/12] Try if unsupported_option_without_values works directly --- packages/ubuntu_widgets/analysis_options.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/ubuntu_widgets/analysis_options.yaml b/packages/ubuntu_widgets/analysis_options.yaml index cf89ba94..59bbb83a 100644 --- a/packages/ubuntu_widgets/analysis_options.yaml +++ b/packages/ubuntu_widgets/analysis_options.yaml @@ -1 +1,5 @@ include: package:ubuntu_lints/analysis_options.yaml + +analyzer: + errors: + unsupported_option_without_values: ignore From f89b584d6ce611ce8f265a61d75133de8eced4b6 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 14:28:32 +0200 Subject: [PATCH 05/12] Remove unsuccessful test --- packages/ubuntu_widgets/analysis_options.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/ubuntu_widgets/analysis_options.yaml b/packages/ubuntu_widgets/analysis_options.yaml index 59bbb83a..4c5f0a1d 100644 --- a/packages/ubuntu_widgets/analysis_options.yaml +++ b/packages/ubuntu_widgets/analysis_options.yaml @@ -1,5 +1,2 @@ include: package:ubuntu_lints/analysis_options.yaml -analyzer: - errors: - unsupported_option_without_values: ignore From 2213ca9ae753c5e6f7fa36b36e8db869e979094e Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 14:50:50 +0200 Subject: [PATCH 06/12] Test without ignore --- packages/ubuntu_lints/lib/analysis_options.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index 07bea3e1..92ad55b4 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -13,7 +13,8 @@ analyzer: errors: # TODO: Remove when SDK is bumped to ^3.8.0 - unsupported_option_without_values: ignore + #unsupported_option_without_values: ignore + formatter: trailing_commas: preserve From 8e3a8f84c9739c086298278a0690daf4bec2faf5 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 15:12:57 +0200 Subject: [PATCH 07/12] try with unsupported_value --- melos.yaml | 2 +- packages/ubuntu_lints/lib/analysis_options.yaml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/melos.yaml b/melos.yaml index 8ce5d36e..dd861d4f 100644 --- a/melos.yaml +++ b/melos.yaml @@ -7,7 +7,7 @@ packages: command: bootstrap: environment: - sdk: ">=3.0.0 <4.0.0" + sdk: ^3.3.0 flutter: ">=3.27.4" dependencies: diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index 92ad55b4..5e72d725 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -14,6 +14,7 @@ analyzer: errors: # TODO: Remove when SDK is bumped to ^3.8.0 #unsupported_option_without_values: ignore + unsupported_value: ignore formatter: From 19caa156d5fcad882d4bb508c24ada8a4696efb6 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 15:14:13 +0200 Subject: [PATCH 08/12] Try what error it gives directly in analysis file --- packages/ubuntu_widgets/analysis_options.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/ubuntu_widgets/analysis_options.yaml b/packages/ubuntu_widgets/analysis_options.yaml index 4c5f0a1d..4b124f1c 100644 --- a/packages/ubuntu_widgets/analysis_options.yaml +++ b/packages/ubuntu_widgets/analysis_options.yaml @@ -1,2 +1,5 @@ include: package:ubuntu_lints/analysis_options.yaml +formatter: + trailing_commas: preserve + From 7fcf753bb07b59c7fc482b9f93bcf988a4096c88 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 15:22:10 +0200 Subject: [PATCH 09/12] Try only in ubuntu_widgets --- packages/ubuntu_lints/lib/analysis_options.yaml | 6 +++--- packages/ubuntu_widgets/analysis_options.yaml | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index 5e72d725..e07d3010 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -14,11 +14,11 @@ analyzer: errors: # TODO: Remove when SDK is bumped to ^3.8.0 #unsupported_option_without_values: ignore - unsupported_value: ignore + #unsupported_value: ignore -formatter: - trailing_commas: preserve +#formatter: +# trailing_commas: preserve linter: rules: diff --git a/packages/ubuntu_widgets/analysis_options.yaml b/packages/ubuntu_widgets/analysis_options.yaml index 4b124f1c..e1cf5cd5 100644 --- a/packages/ubuntu_widgets/analysis_options.yaml +++ b/packages/ubuntu_widgets/analysis_options.yaml @@ -1,5 +1,9 @@ include: package:ubuntu_lints/analysis_options.yaml +analyzer: + errors: + unsupported_option_without_values: ignore + formatter: trailing_commas: preserve From a046509ab535074afd555ab568df800eadfe9ae0 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 15:36:27 +0200 Subject: [PATCH 10/12] Remove errors section --- packages/ubuntu_lints/lib/analysis_options.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index e07d3010..49e6689c 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -11,7 +11,7 @@ analyzer: strict-casts: true strict-raw-types: true - errors: +# errors: # TODO: Remove when SDK is bumped to ^3.8.0 #unsupported_option_without_values: ignore #unsupported_value: ignore From 27f7c745b8835181ed1f7c22927d0c0b85e59fea Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 15:53:55 +0200 Subject: [PATCH 11/12] Reset to initial state --- packages/ubuntu_lints/lib/analysis_options.yaml | 10 ++-------- packages/ubuntu_widgets/analysis_options.yaml | 8 -------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/packages/ubuntu_lints/lib/analysis_options.yaml b/packages/ubuntu_lints/lib/analysis_options.yaml index 49e6689c..2710f84f 100644 --- a/packages/ubuntu_lints/lib/analysis_options.yaml +++ b/packages/ubuntu_lints/lib/analysis_options.yaml @@ -11,14 +11,8 @@ analyzer: strict-casts: true strict-raw-types: true -# errors: - # TODO: Remove when SDK is bumped to ^3.8.0 - #unsupported_option_without_values: ignore - #unsupported_value: ignore - - -#formatter: -# trailing_commas: preserve +formatter: + trailing_commas: preserve linter: rules: diff --git a/packages/ubuntu_widgets/analysis_options.yaml b/packages/ubuntu_widgets/analysis_options.yaml index e1cf5cd5..cf89ba94 100644 --- a/packages/ubuntu_widgets/analysis_options.yaml +++ b/packages/ubuntu_widgets/analysis_options.yaml @@ -1,9 +1 @@ include: package:ubuntu_lints/analysis_options.yaml - -analyzer: - errors: - unsupported_option_without_values: ignore - -formatter: - trailing_commas: preserve - From 984f9c514715e03354f78ae96bab6114ade6c751 Mon Sep 17 00:00:00 2001 From: Lukas Klingsbo Date: Fri, 23 May 2025 15:55:40 +0200 Subject: [PATCH 12/12] Revert melos.yaml change --- melos.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/melos.yaml b/melos.yaml index dd861d4f..8ce5d36e 100644 --- a/melos.yaml +++ b/melos.yaml @@ -7,7 +7,7 @@ packages: command: bootstrap: environment: - sdk: ^3.3.0 + sdk: ">=3.0.0 <4.0.0" flutter: ">=3.27.4" dependencies: