Skip to content

Commit ffbd10f

Browse files
committed
Clean up imports ordering.
Follow recommendations from flake8 regarding import order and grouping. Put two blank lines after the top import block in each file. Import CanError directly from can package in canopen.sdo.client instead of from canopen.network, where it was not even used.
1 parent c781a22 commit ffbd10f

34 files changed

+89
-54
lines changed

canopen/__init__.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
from canopen.network import Network, NodeScanner
2-
from canopen.node import RemoteNode, LocalNode
3-
from canopen.sdo import SdoCommunicationError, SdoAbortedError
4-
from canopen.objectdictionary import import_od, export_od, ObjectDictionary, ObjectDictionaryError
2+
from canopen.node import LocalNode, RemoteNode
3+
from canopen.objectdictionary import (
4+
ObjectDictionary,
5+
ObjectDictionaryError,
6+
export_od,
7+
import_od,
8+
)
59
from canopen.profiles.p402 import BaseNode402
10+
from canopen.sdo import SdoAbortedError, SdoCommunicationError
11+
612
try:
713
from canopen._version import version as __version__
814
except ImportError:

canopen/emcy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import struct
21
import logging
2+
import struct
33
import threading
44
import time
55
from typing import Callable, List, Optional

canopen/lss.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
2-
import time
3-
import struct
42
import queue
3+
import struct
4+
import time
55

66
import canopen.network
77

canopen/network.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
from __future__ import annotations
22

3-
from collections.abc import MutableMapping
43
import logging
54
import threading
5+
from collections.abc import MutableMapping
66
from typing import Callable, Dict, Final, Iterator, List, Optional, Union
77

88
import can
99
from can import Listener
10-
from can import CanError
1110

12-
from canopen.node import RemoteNode, LocalNode
13-
from canopen.sync import SyncProducer
14-
from canopen.timestamp import TimeProducer
15-
from canopen.nmt import NmtMaster
1611
from canopen.lss import LssMaster
17-
from canopen.objectdictionary.eds import import_from_node
12+
from canopen.nmt import NmtMaster
13+
from canopen.node import LocalNode, RemoteNode
1814
from canopen.objectdictionary import ObjectDictionary
15+
from canopen.objectdictionary.eds import import_from_node
16+
from canopen.sync import SyncProducer
17+
from canopen.timestamp import TimeProducer
18+
1919

2020
logger = logging.getLogger(__name__)
2121

canopen/nmt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import threading
21
import logging
32
import struct
3+
import threading
44
import time
55
from typing import Callable, Optional, TYPE_CHECKING
66

canopen/node/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
from canopen.node.remote import RemoteNode
21
from canopen.node.local import LocalNode
2+
from canopen.node.remote import RemoteNode

canopen/node/local.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@
44
from typing import Dict, Union
55

66
import canopen.network
7-
from canopen.node.base import BaseNode
8-
from canopen.sdo import SdoServer, SdoAbortedError
9-
from canopen.pdo import PDO, TPDO, RPDO
10-
from canopen.nmt import NmtSlave
7+
from canopen import objectdictionary
118
from canopen.emcy import EmcyProducer
9+
from canopen.nmt import NmtSlave
10+
from canopen.node.base import BaseNode
1211
from canopen.objectdictionary import ObjectDictionary
13-
from canopen import objectdictionary
12+
from canopen.pdo import PDO, RPDO, TPDO
13+
from canopen.sdo import SdoAbortedError, SdoServer
14+
1415

1516
logger = logging.getLogger(__name__)
1617

canopen/node/remote.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
from __future__ import annotations
22

33
import logging
4-
from typing import Union, TextIO
4+
from typing import TextIO, Union
55

66
import canopen.network
7-
from canopen.sdo import SdoClient, SdoCommunicationError, SdoAbortedError
8-
from canopen.nmt import NmtMaster
97
from canopen.emcy import EmcyConsumer
10-
from canopen.pdo import TPDO, RPDO, PDO
11-
from canopen.objectdictionary import ODRecord, ODArray, ODVariable, ObjectDictionary
8+
from canopen.nmt import NmtMaster
129
from canopen.node.base import BaseNode
10+
from canopen.objectdictionary import ODArray, ODRecord, ODVariable, ObjectDictionary
11+
from canopen.pdo import PDO, RPDO, TPDO
12+
from canopen.sdo import SdoAbortedError, SdoClient, SdoCommunicationError
13+
1314

1415
logger = logging.getLogger(__name__)
1516

canopen/objectdictionary/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
"""
22
Object Dictionary module
33
"""
4+
45
from __future__ import annotations
56

7+
import logging
68
import struct
9+
from collections.abc import Mapping, MutableMapping
710
from typing import Dict, Iterator, List, Optional, TextIO, Union
8-
from collections.abc import MutableMapping, Mapping
9-
import logging
1011

1112
from canopen.objectdictionary.datatypes import *
1213
from canopen.objectdictionary.datatypes import IntegerN, UnsignedN
1314
from canopen.utils import pretty_index
1415

16+
1517
logger = logging.getLogger(__name__)
1618

1719

canopen/objectdictionary/datatypes.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import struct
22

3+
34
BOOLEAN = 0x1
45
INTEGER8 = 0x2
56
INTEGER16 = 0x3

0 commit comments

Comments
 (0)