Skip to content

Commit cca496c

Browse files
HaizzzHaizzz
authored
Post a warning if comment has preamble (#25)
1 parent 866e3a4 commit cca496c

File tree

9 files changed

+220
-14
lines changed

9 files changed

+220
-14
lines changed

‎__tests__/fixtures/issue_comment/github/create_comment_body_expected_warning.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"body": "Your last comment looked similar to a command but Rocketbot couldn't understand it. Were you trying to [run a build](https://github.com/canva-public/rocketbot/blob/main/docs/getting-started.md#run-a-build)?"
3+
}

‎__tests__/fixtures/issue_comment/github/create_comment_warning.json‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"url": "https://api.github.com/repos/some-org/some-repo/issues/comments/1111111",
3+
"html_url": "https://github.com/some-org/some-repo/pull/1111111#issuecomment-280987786",
4+
"issue_url": "https://api.github.com/repos/some-org/some-repo/issues/1111111",
5+
"id": 280987786,
6+
"user": {
7+
"login": "some-user",
8+
"id": 11111111,
9+
"avatar_url": "https://avatars.githubusercontent.com/u/11111111?v=3",
10+
"gravatar_id": "",
11+
"url": "https://api.github.com/users/some-user",
12+
"html_url": "https://github.com/some-user",
13+
"followers_url": "https://api.github.com/users/some-user/followers",
14+
"following_url": "https://api.github.com/users/some-user/following{/other_user}",
15+
"gists_url": "https://api.github.com/users/some-user/gists{/gist_id}",
16+
"starred_url": "https://api.github.com/users/some-user/starred{/owner}{/repo}",
17+
"subscriptions_url": "https://api.github.com/users/some-user/subscriptions",
18+
"organizations_url": "https://api.github.com/users/some-user/orgs",
19+
"repos_url": "https://api.github.com/users/some-user/repos",
20+
"events_url": "https://api.github.com/users/some-user/events{/privacy}",
21+
"received_events_url": "https://api.github.com/users/some-user/received_events",
22+
"type": "User",
23+
"site_admin": false
24+
},
25+
"created_at": "2017-02-20T04:53:38Z",
26+
"updated_at": "2017-02-20T04:53:38Z",
27+
"body": "Your last comment looked similar to a command but Rocketbot couldn't understand it. Were you trying to [run a build](https://github.com/canva-public/rocketbot/blob/main/docs/getting-started.md#run-a-build)?"
28+
}

‎__tests__/fixtures/issue_comment/lambda_request_has_emoji.json‎

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
{
2+
"resource": "/StartBuildKiteBuild",
3+
"path": "/StartBuildKiteBuild",
4+
"httpMethod": "POST",
5+
"headers": {
6+
"Accept": "*/*",
7+
"CloudFront-Forwarded-Proto": "https",
8+
"CloudFront-Is-Desktop-Viewer": "true",
9+
"CloudFront-Is-Mobile-Viewer": "false",
10+
"CloudFront-Is-SmartTV-Viewer": "false",
11+
"CloudFront-Is-Tablet-Viewer": "false",
12+
"CloudFront-Viewer-Country": "US",
13+
"content-type": "application/json",
14+
"Host": "xxxxxxxxxx.execute-api.us-east-1.amazonaws.com",
15+
"User-Agent": "GitHub-Hookshot/886c556",
16+
"Via": "1.1 8008015354a3ca72f56c382a1d1cfe9f.cloudfront.net (CloudFront)",
17+
"X-Amz-Cf-Id": "HgjErOsJdhxutD-z-u08qkaYI3Tx6-IFVsEjwS5N3YmNWq66ZNmhrw==",
18+
"X-Amzn-Trace-Id": "Root=1-58a3f60a-4bc956ce51375773441fc28d",
19+
"X-Forwarded-For": "192.30.252.45, 54.239.134.103",
20+
"X-Forwarded-Port": "443",
21+
"X-Forwarded-Proto": "https",
22+
"X-GitHub-Delivery": "8d962100-f348-11e6-9863-89383323f38a",
23+
"X-GitHub-Event": "issue_comment"
24+
},
25+
"queryStringParameters": null,
26+
"pathParameters": null,
27+
"stageVariables": null,
28+
"requestContext": {
29+
"accountId": "111111100000",
30+
"resourceId": "m4cq3t",
31+
"stage": "prod",
32+
"requestId": "8e016671-f348-11e6-91e9-b966b3b9522f",
33+
"identity": {
34+
"cognitoIdentityPoolId": null,
35+
"accountId": null,
36+
"cognitoIdentityId": null,
37+
"caller": null,
38+
"apiKey": null,
39+
"sourceIp": "192.30.252.45",
40+
"accessKey": null,
41+
"cognitoAuthenticationType": null,
42+
"cognitoAuthenticationProvider": null,
43+
"userArn": null,
44+
"userAgent": "GitHub-Hookshot/886c556",
45+
"user": null
46+
},
47+
"resourcePath": "/StartBuildKiteBuild",
48+
"httpMethod": "POST",
49+
"apiId": "hgcoqhi9i5"
50+
},
51+
"body": "{\"action\":\"created\",\"issue\":{\"url\":\"https://api.github.com/repos/some-org/some-repo/issues/9500\",\"repository_url\":\"https://api.github.com/repos/some-org/some-repo\",\"labels_url\":\"https://api.github.com/repos/some-org/some-repo/issues/9500/labels{/name}\",\"comments_url\":\"https://api.github.com/repos/some-org/some-repo/issues/9500/comments\",\"events_url\":\"https://api.github.com/repos/some-org/some-repo/issues/9500/events\",\"html_url\":\"https://github.com/some-org/some-repo/pull/9500\",\"id\":206679442,\"number\":9500,\"title\":\"test\",\"user\":{\"login\":\"some-user\",\"id\":111111,\"avatar_url\":\"https://avatars.githubusercontent.com/u/111111?v=3\",\"gravatar_id\":\"\",\"url\":\"https://api.github.com/users/some-user\",\"html_url\":\"https://github.com/some-user\",\"followers_url\":\"https://api.github.com/users/some-user/followers\",\"following_url\":\"https://api.github.com/users/some-user/following{/other_user}\",\"gists_url\":\"https://api.github.com/users/some-user/gists{/gist_id}\",\"starred_url\":\"https://api.github.com/users/some-user/starred{/owner}{/repo}\",\"subscriptions_url\":\"https://api.github.com/users/some-user/subscriptions\",\"organizations_url\":\"https://api.github.com/users/some-user/orgs\",\"repos_url\":\"https://api.github.com/users/some-user/repos\",\"events_url\":\"https://api.github.com/users/some-user/events{/privacy}\",\"received_events_url\":\"https://api.github.com/users/some-user/received_events\",\"type\":\"User\",\"site_admin\":false},\"labels\":[],\"state\":\"open\",\"locked\":false,\"assignee\":null,\"assignees\":[],\"milestone\":null,\"comments\":27,\"created_at\":\"2017-02-10T01:15:00Z\",\"updated_at\":\"2017-02-15T06:32:42Z\",\"closed_at\":null,\"pull_request\":{\"url\":\"https://api.github.com/repos/some-org/some-repo/pulls/9500\",\"html_url\":\"https://github.com/some-org/some-repo/pull/9500\",\"diff_url\":\"https://github.com/some-org/some-repo/pull/9500.diff\",\"patch_url\":\"https://github.com/some-org/some-repo/pull/9500.patch\"},\"body\":\"This is a test for the github-control bot.\\r\\n\\r\\nEdited\"},\"comment\":{\"url\":\"https://api.github.com/repos/some-org/some-repo/issues/comments/1111111\",\"html_url\":\"https://github.com/some-org/some-repo/pull/9500#issuecomment-279928810\",\"issue_url\":\"https://api.github.com/repos/some-org/some-repo/issues/9500\",\"id\":279928810,\"user\":{\"login\":\"some-user\",\"id\":111111,\"avatar_url\":\"https://avatars.githubusercontent.com/u/111111?v=3\",\"gravatar_id\":\"\",\"url\":\"https://api.github.com/users/some-user\",\"html_url\":\"https://github.com/some-user\",\"followers_url\":\"https://api.github.com/users/some-user/followers\",\"following_url\":\"https://api.github.com/users/some-user/following{/other_user}\",\"gists_url\":\"https://api.github.com/users/some-user/gists{/gist_id}\",\"starred_url\":\"https://api.github.com/users/some-user/starred{/owner}{/repo}\",\"subscriptions_url\":\"https://api.github.com/users/some-user/subscriptions\",\"organizations_url\":\"https://api.github.com/users/some-user/orgs\",\"repos_url\":\"https://api.github.com/users/some-user/repos\",\"events_url\":\"https://api.github.com/users/some-user/events{/privacy}\",\"received_events_url\":\"https://api.github.com/users/some-user/received_events\",\"type\":\"User\",\"site_admin\":false},\"created_at\":\"2017-02-15T06:32:42Z\",\"updated_at\":\"2017-02-15T06:32:42Z\",\"body\":\"I'm an emoji connoisseur so I put the :rocket: emoji everywhere\"},\"repository\":{\"id\":1111111,\"name\":\"some-repo\",\"full_name\":\"some-org/some-repo\",\"owner\":{\"login\":\"some-org\",\"id\":1111111,\"avatar_url\":\"https://avatars.githubusercontent.com/u/1111111?v=3\",\"gravatar_id\":\"\",\"url\":\"https://api.github.com/users/some-org\",\"html_url\":\"https://github.com/some-org\",\"followers_url\":\"https://api.github.com/users/some-org/followers\",\"following_url\":\"https://api.github.com/users/some-org/following{/other_user}\",\"gists_url\":\"https://api.github.com/users/some-org/gists{/gist_id}\",\"starred_url\":\"https://api.github.com/users/some-org/starred{/owner}{/repo}\",\"subscriptions_url\":\"https://api.github.com/users/some-org/subscriptions\",\"organizations_url\":\"https://api.github.com/users/some-org/orgs\",\"repos_url\":\"https://api.github.com/users/some-org/repos\",\"events_url\":\"https://api.github.com/users/some-org/events{/privacy}\",\"received_events_url\":\"https://api.github.com/users/some-org/received_events\",\"type\":\"Organization\",\"site_admin\":false},\"private\":true,\"html_url\":\"https://github.com/some-org/some-repo\",\"description\":\"Some description\",\"fork\":false,\"url\":\"https://api.github.com/repos/some-org/some-repo\",\"forks_url\":\"https://api.github.com/repos/some-org/some-repo/forks\",\"keys_url\":\"https://api.github.com/repos/some-org/some-repo/keys{/key_id}\",\"collaborators_url\":\"https://api.github.com/repos/some-org/some-repo/collaborators{/collaborator}\",\"teams_url\":\"https://api.github.com/repos/some-org/some-repo/teams\",\"hooks_url\":\"https://api.github.com/repos/some-org/some-repo/hooks\",\"issue_events_url\":\"https://api.github.com/repos/some-org/some-repo/issues/events{/number}\",\"events_url\":\"https://api.github.com/repos/some-org/some-repo/events\",\"assignees_url\":\"https://api.github.com/repos/some-org/some-repo/assignees{/user}\",\"branches_url\":\"https://api.github.com/repos/some-org/some-repo/branches{/branch}\",\"tags_url\":\"https://api.github.com/repos/some-org/some-repo/tags\",\"blobs_url\":\"https://api.github.com/repos/some-org/some-repo/git/blobs{/sha}\",\"git_tags_url\":\"https://api.github.com/repos/some-org/some-repo/git/tags{/sha}\",\"git_refs_url\":\"https://api.github.com/repos/some-org/some-repo/git/refs{/sha}\",\"trees_url\":\"https://api.github.com/repos/some-org/some-repo/git/trees{/sha}\",\"statuses_url\":\"https://api.github.com/repos/some-org/some-repo/statuses/{sha}\",\"languages_url\":\"https://api.github.com/repos/some-org/some-repo/languages\",\"stargazers_url\":\"https://api.github.com/repos/some-org/some-repo/stargazers\",\"contributors_url\":\"https://api.github.com/repos/some-org/some-repo/contributors\",\"subscribers_url\":\"https://api.github.com/repos/some-org/some-repo/subscribers\",\"subscription_url\":\"https://api.github.com/repos/some-org/some-repo/subscription\",\"commits_url\":\"https://api.github.com/repos/some-org/some-repo/commits{/sha}\",\"git_commits_url\":\"https://api.github.com/repos/some-org/some-repo/git/commits{/sha}\",\"comments_url\":\"https://api.github.com/repos/some-org/some-repo/comments{/number}\",\"issue_comment_url\":\"https://api.github.com/repos/some-org/some-repo/issues/comments{/number}\",\"contents_url\":\"https://api.github.com/repos/some-org/some-repo/contents/{+path}\",\"compare_url\":\"https://api.github.com/repos/some-org/some-repo/compare/{base}...{head}\",\"merges_url\":\"https://api.github.com/repos/some-org/some-repo/merges\",\"archive_url\":\"https://api.github.com/repos/some-org/some-repo/{archive_format}{/ref}\",\"downloads_url\":\"https://api.github.com/repos/some-org/some-repo/downloads\",\"issues_url\":\"https://api.github.com/repos/some-org/some-repo/issues{/number}\",\"pulls_url\":\"https://api.github.com/repos/some-org/some-repo/pulls{/number}\",\"milestones_url\":\"https://api.github.com/repos/some-org/some-repo/milestones{/number}\",\"notifications_url\":\"https://api.github.com/repos/some-org/some-repo/notifications{?since,all,participating}\",\"labels_url\":\"https://api.github.com/repos/some-org/some-repo/labels{/name}\",\"releases_url\":\"https://api.github.com/repos/some-org/some-repo/releases{/id}\",\"deployments_url\":\"https://api.github.com/repos/some-org/some-repo/deployments\",\"created_at\":\"2012-10-15T08:14:27Z\",\"updated_at\":\"2017-02-05T22:21:39Z\",\"pushed_at\":\"2017-02-15T06:25:23Z\",\"git_url\":\"git://github.com/some-org/some-repo.git\",\"ssh_url\":\"git@github.com:some-org/some-repo.git\",\"clone_url\":\"https://github.com/some-org/some-repo.git\",\"svn_url\":\"https://github.com/some-org/some-repo\",\"homepage\":\"\",\"size\":375432,\"stargazers_count\":9,\"watchers_count\":9,\"language\":\"JavaScript\",\"has_issues\":false,\"has_downloads\":true,\"has_wiki\":false,\"has_pages\":false,\"forks_count\":0,\"mirror_url\":null,\"open_issues_count\":349,\"forks\":0,\"open_issues\":349,\"watchers\":9,\"default_branch\":\"master\"},\"organization\":{\"login\":\"some-org\",\"id\":1111111,\"url\":\"https://api.github.com/orgs/Canva\",\"repos_url\":\"https://api.github.com/orgs/some-org/repos\",\"events_url\":\"https://api.github.com/orgs/some-org/events\",\"hooks_url\":\"https://api.github.com/orgs/some-org/hooks\",\"issues_url\":\"https://api.github.com/orgs/some-org/issues\",\"members_url\":\"https://api.github.com/orgs/some-org/members{/member}\",\"public_members_url\":\"https://api.github.com/orgs/some-org/public_members{/member}\",\"avatar_url\":\"https://avatars.githubusercontent.com/u/1111111?v=3\",\"description\":null},\"sender\":{\"login\":\"some-user\",\"id\":111111,\"avatar_url\":\"https://avatars.githubusercontent.com/u/111111?v=3\",\"gravatar_id\":\"\",\"url\":\"https://api.github.com/users/some-user\",\"html_url\":\"https://github.com/some-user\",\"followers_url\":\"https://api.github.com/users/some-user/followers\",\"following_url\":\"https://api.github.com/users/some-user/following{/other_user}\",\"gists_url\":\"https://api.github.com/users/some-user/gists{/gist_id}\",\"starred_url\":\"https://api.github.com/users/some-user/starred{/owner}{/repo}\",\"subscriptions_url\":\"https://api.github.com/users/some-user/subscriptions\",\"organizations_url\":\"https://api.github.com/users/some-user/orgs\",\"repos_url\":\"https://api.github.com/users/some-user/repos\",\"events_url\":\"https://api.github.com/users/some-user/events{/privacy}\",\"received_events_url\":\"https://api.github.com/users/some-user/received_events\",\"type\":\"User\",\"site_admin\":false}}",
52+
"isBase64Encoded": false
53+
}

0 commit comments

Comments
 (0)