correct and refactor the instance analyzer feature

Author: dbajet

canvas-plugin-assistant/agents/instance-analyzer.md

@@ -8,179 +8,19 @@ model: sonnet
 
 You help solutions consultants understand a Canvas Medical instance's configuration before building plugins. This analysis informs plugin design decisions and identifies existing resources to leverage.
 
-## When to Use This Agent
+## Instructions
 
-Use this agent when:
-- Starting a new plugin project and need to understand the target environment
-- Need to know what teams, roles, or questionnaires exist for plugin integration
-- Want to document current instance configuration for reference
-- Checking what plugins are already installed
+Follow the **instance-analyze** skill for the complete workflow:
 
-## Workflow
+1. Get the target instance name (ask user or use provided argument)
+2. Read credentials from `~/.canvas/credentials.ini`
+3. Run the scraper script to fetch configuration
+4. Generate a comprehensive markdown report
+5. Save to `{workspace_dir}/.cpa-workflow-artifacts/instance-config-{hostname}.md`
 
-### Step 1: Get Instance Information
+The skill contains:
+- Detailed step-by-step workflow
+- Report format template
+- Credentials setup instructions
+- Integration with plugin-spec.md
 
-Ask the user which instance to analyze:
-
-```json
-{
-  "questions": [
-    {
-      "question": "What Canvas instance should I analyze?",
-      "header": "Instance",
-      "options": [
-        {"label": "plugin-testing", "description": "Canvas test/sandbox instance"},
-        {"label": "Other", "description": "I'll provide the hostname"}
-      ],
-      "multiSelect": false
-    }
-  ]
-}
-```
-
-### Step 2: Read Credentials and Fetch Configuration
-
-Read credentials from `~/.canvas/credentials.ini`:
-
-```bash
-# Read the credentials file to get root_password for the instance
-cat ~/.canvas/credentials.ini
-```
-
-The instance section should contain:
-```ini
-[instance-name]
-client_id=xxx
-client_secret=yyy
-root_password=zzz
-```
-
-If `root_password` is missing, tell the user:
-> "Please add `root_password` to your `~/.canvas/credentials.ini` under the `[{instance}]` section, then try again."
-
-Use browser automation to:
-
-1. **Login to Admin Portal**
-   - Navigate to `https://{hostname}.canvasmedical.com/admin/`
-   - Username: `root`
-   - Password: `root_password` from credentials.ini
-
-2. **Extract Configuration** from these pages:
-   - `/admin/core/careteamrole/` - Roles
-   - `/admin/core/team/` - Teams
-   - `/admin/core/questionnaire/` - Questionnaires
-   - `/admin/core/notetypelabel/` - Note types
-   - `/admin/scheduling/appointmenttypecategory/` - Appointment types
-   - `/admin/plugin/pluginiopackage/` - Installed plugins
-
-### Step 3: Generate Report
-
-Create a comprehensive markdown report:
-
-```markdown
-# Canvas Instance Configuration Report
-
-**Instance**: {hostname}.canvasmedical.com
-**Generated**: {date}
-
-## Summary
-
-| Category | Count |
-|----------|-------|
-| Roles | X |
-| Teams | X |
-| Questionnaires | X |
-| Note Types | X |
-| Appointment Types | X |
-| Installed Plugins | X |
-
-## Roles
-
-| Name | Description |
-|------|-------------|
-| ... | ... |
-
-## Teams
-
-| Name | Members | Description |
-|------|---------|-------------|
-| ... | ... | ... |
-
-## Questionnaires
-
-| Name | Code | Status |
-|------|------|--------|
-| ... | ... | Active/Inactive |
-
-## Note Types
-
-| Name | Category |
-|------|----------|
-| ... | ... |
-
-## Appointment Types
-
-| Name | Duration | Category |
-|------|----------|----------|
-| ... | ... | ... |
-
-## Installed Plugins
-
-| Name | Version | Status |
-|------|---------|--------|
-| ... | ... | Active/Inactive |
-
-## Plugin Development Recommendations
-
-Based on this configuration:
-
-- **Available Teams for Task Assignment**: [list teams that could receive tasks]
-- **Relevant Questionnaires**: [questionnaires that might be relevant to the use case]
-- **Existing Plugins**: [any plugins that might conflict or complement new development]
-```
-
-### Step 4: Save Report
-
-Save the report to `instance-config-{hostname}.md` in the current working directory.
-
-Tell the user the file path and offer to explain any section in detail.
-
-## Important Notes
-
-1. **Credentials Security**: Never log or store credentials. Use them only for the session.
-
-2. **Read-Only**: This agent only reads configuration. It does not modify anything.
-
-3. **Relevance Filtering**: When presenting the report, highlight items most relevant to the plugin being developed (if known from a previous brainstorming session).
-
-4. **Plugin Conflicts**: Flag any installed plugins that might interact with what's being built.
-
-## Integration with Brainstorm Agent
-
-If a `{workspace_dir}/.cpa-workflow-artifacts/plugin-spec.md` file exists (where workspace_dir is git repository root), read it and tailor the report to highlight:
-- Teams that match the spec's task assignment needs
-- Questionnaires relevant to the spec's data requirements
-- Existing plugins that might overlap
-
-## Example Usage
-
-**User**: "I need to analyze the plugin-testing instance before building a vitals alert plugin"
-
-**You**: *[Uses AskUserQuestion to confirm instance]*
-
-**User**: Confirms plugin-testing
-
-**You**: "I'll need admin credentials to fetch the configuration. Please provide them securely."
-
-**User**: Provides credentials
-
-**You**: *[Fetches configuration from admin pages]*
-
-**You**: "I've analyzed the plugin-testing instance and saved the report to `instance-config-plugin-testing.md`.
-
-Key findings relevant to your vitals alert plugin:
-- **3 clinical teams** available for task assignment: Nursing, Care Coordination, Providers
-- **No existing vitals-related plugins** installed - no conflicts expected
-- **12 active questionnaires** - none specifically for vitals alerts
-
-Would you like me to explain any section in more detail?"

canvas-plugin-assistant/commands/analyze-instance.md

@@ -4,34 +4,6 @@ Analyze a Canvas instance's configuration to understand the target environment.
 
 ## Instructions
 
-Use the **instance-analyzer** agent to document the Canvas instance configuration.
+Use the **instance-analyzer** agent to analyze the Canvas instance configuration. The agent will use the **instance-analyze** skill for detailed guidance.
 
-1. Ask which Canvas instance to analyze (e.g., plugin-testing, customer dev instance)
-2. Read credentials from `~/.canvas/credentials.ini`:
-   - The instance section should contain `client_id`, `client_secret`, and `root_password`
-   - If `root_password` is missing, tell the user to add it to their credentials file
-3. Extract configuration from admin portal using the root_password:
-   - Roles
-   - Teams
-   - Questionnaires
-   - Note types
-   - Appointment types
-   - Installed plugins
-4. Generate `instance-config-{hostname}.md` report
-5. If `{workspace_dir}/.cpa-workflow-artifacts/plugin-spec.md` exists (where workspace_dir is the git repository root), highlight configuration relevant to the planned plugin
-
-## Credentials Setup
-
-If the user hasn't configured credentials, instruct them:
-
-> Add `root_password` to your `~/.canvas/credentials.ini` under the instance section:
-> ```ini
-> [plugin-testing]
-> client_id=your_client_id
-> client_secret=your_client_secret
-> root_password=your_admin_password
-> ```
-
-## Arguments
-
-If the user provides an instance name with the command (e.g., `/analyze-instance plugin-testing`), use that as the target instance.
+If the user provides an instance name with the command (e.g., `/analyze-instance plugin-testing`), pass that to the agent as the target instance.