Skip to content

Miscellaneous code quality issues #34

@csande

Description

@csande
  • Inline imports when they should be at the top of the file
  • Django query optimization (i.e. fetching too much data, missing use of select_related, etc.)
  • Unsafe default values or assumptions (e.g. assuming a value for an instance hostname)
  • Repeated code which should be helper functions for consistency
  • Logical assumptions that may not hold as plugin changes (i.e. unwise use of an if-else statement)
  • Incorrectly returning 200 statuses for error responses from SimpleAPI endpoints

Examples highlighted here: https://github.com/canvas-medical/gtm-extensions/pull/97

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions