Skip to content

Commit 034b8a8

Browse files
committed
Add finalName and fix the java doc
1 parent 963dcd7 commit 034b8a8

File tree

3 files changed

+32
-9
lines changed

3 files changed

+32
-9
lines changed

cds-feature-auditlog-ng/pom.xml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,40 @@
5252
</dependencies>
5353

5454
<build>
55+
<finalName>${project.artifactId}</finalName>
5556
<plugins>
5657
<plugin>
5758
<artifactId>maven-surefire-plugin</artifactId>
5859
<configuration>
5960
<failIfNoTests>false</failIfNoTests>
6061
</configuration>
6162
</plugin>
63+
<plugin>
64+
<artifactId>maven-javadoc-plugin</artifactId>
65+
<configuration>
66+
<skip>${skipDuringDeploy}</skip>
67+
<failOnError>true</failOnError>
68+
<doclint>all,-missing</doclint>
69+
</configuration>
70+
<executions>
71+
<execution>
72+
<goals>
73+
<goal>jar</goal>
74+
</goals>
75+
</execution>
76+
</executions>
77+
</plugin>
78+
79+
<plugin>
80+
<artifactId>maven-source-plugin</artifactId>
81+
<executions>
82+
<execution>
83+
<goals>
84+
<goal>jar</goal>
85+
</goals>
86+
</execution>
87+
</executions>
88+
</plugin>
6289
</plugins>
6390
</build>
6491
</project>

cds-feature-auditlog-ng/src/main/java/com/sap/cds/feature/auditlog/ng/AuditLogNGCommunicator.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@
2525
import com.sap.cloud.sdk.cloudplatform.resilience.ResilienceDecorator;
2626
import com.sap.cloud.sdk.cloudplatform.resilience.ResilienceIsolationMode;
2727

28-
/**
29-
* Implementation for an audit log {@link Communicator} which provides
30-
* connectivity to the audit log api via the Cloud SDK.
31-
*/
3228
public class AuditLogNGCommunicator {
3329

3430
private static final Logger logger = LoggerFactory.getLogger(AuditLogNGCommunicator.class);

cds-feature-auditlog-ng/src/main/java/com/sap/cds/feature/auditlog/ng/CertificateHttpClientConfig.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
/**
3636
* Provides a configurable HTTP client for certificate-based authentication with retry logic.
3737
* Usage example:
38-
* CloseableHttpClient client = RetryHttpClientConfig.builder()
38+
* CloseableHttpClient client = CertificateHttpClientConfig.builder()
3939
* .certPem(certString)
4040
* .keyPem(keyString)
4141
* .keyPassphrase(passphrase) // optional, only for encrypted keys
@@ -84,7 +84,7 @@ public CloseableHttpClient getHttpClient() {
8484
}
8585

8686
/**
87-
* Returns a builder for {@link RetryHttpClientConfig}.
87+
* Returns a builder for {@link CertificateHttpClientConfig}.
8888
*
8989
* @return a new Builder instance
9090
*/
@@ -93,7 +93,7 @@ public static Builder builder() {
9393
}
9494

9595
/**
96-
* Builder for {@link RetryHttpClientConfig}.
96+
* Builder for {@link CertificateHttpClientConfig}.
9797
* <p>
9898
* All fields are optional except for certPem and keyPem, which are required.
9999
* </p>
@@ -152,8 +152,8 @@ public Builder timeoutMillis(int timeoutMillis) {
152152
return this;
153153
}
154154
/**
155-
* Builds the {@link RetryHttpClientConfig} instance.
156-
* @return a configured RetryHttpClientConfig
155+
* Builds the {@link CertificateHttpClientConfig} instance.
156+
* @return a configured CertificateHttpClientConfig
157157
* @throws IllegalArgumentException if certPem or keyPem is missing
158158
*/
159159
public CertificateHttpClientConfig build() {

0 commit comments

Comments
 (0)