sonar fix

Author: rishikunnath2747

sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMCreateAttachmentsHandler.java

@@ -124,12 +124,18 @@ private void processAttachment(
       CmisDocument cmisDocument = new CmisDocument();
       cmisDocument.setFileName(filenameInRequest);
       cmisDocument.setObjectId(objectId);
-      if (fileNameInDB == null && filenameInRequest != null) {
-        updatedSecondaryProperties.put("filename", filenameInRequest);
-      } else if (!fileNameInDB.equals(filenameInRequest) && filenameInRequest != null) {
-        updatedSecondaryProperties.put("filename", filenameInRequest);
-      } else if (filenameInRequest == null) {
-        throw new ServiceException("Filename cannot be empty");
+      if (fileNameInDB == null) {
+        if (filenameInRequest != null) {
+          updatedSecondaryProperties.put("filename", filenameInRequest);
+        } else {
+          throw new ServiceException("Filename cannot be empty");
+        }
+      } else {
+        if (filenameInRequest == null) {
+          throw new ServiceException("Filename cannot be empty");
+        } else if (!fileNameInDB.equals(filenameInRequest)) {
+          updatedSecondaryProperties.put("filename", filenameInRequest);
+        }
       }
       int responseCode =
           sdmService.updateAttachments(

sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMUpdateAttachmentsHandler.java

@@ -133,12 +133,18 @@ public void processAttachment(
     CmisDocument cmisDocument = new CmisDocument();
     cmisDocument.setFileName(filenameInRequest);
     cmisDocument.setObjectId(objectId);
-    if (fileNameInDB == null && filenameInRequest != null) {
-      updatedSecondaryProperties.put("filename", filenameInRequest);
-    } else if (!fileNameInDB.equals(filenameInRequest) && filenameInRequest != null) {
-      updatedSecondaryProperties.put("filename", filenameInRequest);
-    } else if (filenameInRequest == null) {
-      throw new ServiceException("Filename cannot be empty");
+    if (fileNameInDB == null) {
+      if (filenameInRequest != null) {
+        updatedSecondaryProperties.put("filename", filenameInRequest);
+      } else {
+        throw new ServiceException("Filename cannot be empty");
+      }
+    } else {
+      if (filenameInRequest == null) {
+        throw new ServiceException("Filename cannot be empty");
+      } else if (!fileNameInDB.equals(filenameInRequest)) {
+        updatedSecondaryProperties.put("filename", filenameInRequest);
+      }
     }
     if (!updatedSecondaryProperties.isEmpty()) {
       int responseCode =