Merge pull request #351 from cap-java/fileNameIssueInCopyafterRename

Fix for incorrect filename if copying attachments after renaming the source attachment

Author: yashmeet29

sdm/pom.xml

@@ -529,7 +529,7 @@
             <plugin>
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
-                <version>0.8.12</version>
+                <version>0.8.14</version>
                 <configuration>
                     <excludes>
                         <exclude>

sdm/src/main/java/com/sap/cds/sdm/service/SDMServiceImpl.java

@@ -687,7 +687,7 @@ public List<String> copyAttachment(
 
         JSONObject jsonObject = new JSONObject(responseBody);
         JSONObject props = jsonObject.getJSONObject("succinctProperties");
-        String fileName = props.optString("cmis:contentStreamFileName");
+        String fileName = props.optString("cmis:name");
         String mimeType = props.optString("cmis:contentStreamMimeType");
         String objectId = props.optString("cmis:objectId");
         return List.of(fileName, mimeType, objectId);

sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMCustomServiceHandler.java

@@ -231,10 +231,6 @@ private void createDraftEntries(CreateDraftEntriesRequest request) {
 
       String fileName = attachmentMetadata.get(0);
       String mimeType = attachmentMetadata.get(1);
-      if (mimeType.equalsIgnoreCase("application/internet-shortcut")) {
-        int dotIndex = fileName.lastIndexOf('.');
-        fileName = fileName.substring(0, dotIndex);
-      }
       String newObjectId = attachmentMetadata.get(2);
 
       updatedFields.put("objectId", newObjectId);

sdm/src/test/java/unit/com/sap/cds/sdm/service/SDMServiceImplTest.java

@@ -1498,7 +1498,7 @@ public void testCopyAttachment_Success() throws Exception {
     // Prepare mock response JSON
     String responseBody =
         "{\"succinctProperties\":{"
-            + "\"cmis:contentStreamFileName\":\"file1.pdf\","
+            + "\"cmis:name\":\"file1.pdf\","
             + "\"cmis:contentStreamMimeType\":\"application/pdf\","
             + "\"cmis:objectId\":\"obj123\"}}";