Skip to content

Commit 010c0b3

Browse files
committed
clearer option naming
1 parent 33339e3 commit 010c0b3

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/feature-toggles.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -808,8 +808,8 @@ class FeatureToggles {
808808
configFile: configFilepath,
809809
configFiles: configFilepaths,
810810
configAuto,
811-
redisCredentials,
812-
redisClientOptions,
811+
customRedisCredentials,
812+
customRedisClientOptions,
813813
} = {}) {
814814
if (this.__isInitialized) {
815815
return;
@@ -868,7 +868,7 @@ class FeatureToggles {
868868
);
869869
}
870870

871-
redis.setCustomOptions(redisCredentials, redisClientOptions);
871+
redis.setCustomOptions(customRedisCredentials, customRedisClientOptions);
872872
const redisIntegrationMode = await redis.getIntegrationMode();
873873
if (redisIntegrationMode !== REDIS_INTEGRATION_MODE.NO_REDIS) {
874874
try {
@@ -954,6 +954,8 @@ class FeatureToggles {
954954
* @property {Config} [config]
955955
* @property {string} [configFile]
956956
* @property {Config} [configAuto]
957+
* @property {object} [customRedisCredentials]
958+
* @property {object} [customRedisClientOptions]
957959
*/
958960
/**
959961
* Initialize needs to run and finish before other APIs are called. It processes the configuration, sets up

src/plugin.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,16 +170,16 @@ const activate = async () => {
170170
}
171171

172172
const configAuto = await _discoverFtsAutoConfig();
173-
const { credentials: redisCredentials, options: redisClientOptions } =
173+
const { credentials: customRedisCredentials, options: customRedisClientOptions } =
174174
cds.requires["redis-featureToggles"] || cds.requires["redis"];
175175

176176
await toggles.initializeFeatures({
177177
config: envFeatureToggles?.config,
178178
configFile: envFeatureToggles?.configFile,
179179
configFiles: envFeatureToggles?.configFiles,
180180
configAuto,
181-
redisCredentials,
182-
redisClientOptions,
181+
customRedisCredentials,
182+
customRedisClientOptions,
183183
});
184184

185185
_registerFeatureProvider(envFeatureToggles);

src/redis-adapter.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,9 +211,9 @@ const _closeClientBase = async (client) => {
211211
}
212212
};
213213

214-
const setCustomOptions = (credentials, clientOptions) => {
215-
__customCredentials = credentials;
216-
__customClientOptions = clientOptions;
214+
const setCustomOptions = (customCredentials, customClientOptions) => {
215+
__customCredentials = customCredentials;
216+
__customClientOptions = customClientOptions;
217217
};
218218

219219
const _canGetClient = async () => {

0 commit comments

Comments
 (0)