tests and such 2

Author: rlindner81

test/__mocks__/mock-redis-credentials.json

@@ -0,0 +1,41 @@
+{
+  "AWS-cluster": {
+    "cluster_mode": true,
+    "hostname": "clustercfg.rg-0c94f0c1-db0a-495d-b385-4a44a87fc398.vwvwdz.euc1.cache.amazonaws.com",
+    "password": "mock-password",
+    "port": 3991,
+    "tls": true,
+    "uri": "rediss://:mock-password@clustercfg.rg-0c94f0c1-db0a-495d-b385-4a44a87fc398.vwvwdz.euc1.cache.amazonaws.com:3991",
+    "urls": {
+      "api_server": "https://api-backing-services.eu10-canary.data.services.cloud.sap"
+    }
+  },
+  "AZURE": {
+    "password": "mock-password",
+    "hostname": "redis-389395bc-9765-4d9a-ba6b-7252c136abab.redis.cache.windows.net",
+    "port": 6380,
+    "uri": "rediss://:mock-password@redis-389395bc-9765-4d9a-ba6b-7252c136abab.redis.cache.windows.net:6380",
+    "cluster_mode": false,
+    "urls": {
+      "api_server": "https://api-backing-services.eu20-001.data.services.cloud.sap"
+    },
+    "tls": {
+      "host": "redis-389395bc-9765-4d9a-ba6b-7252c136abab.redis.cache.windows.net",
+      "port": 6380,
+      "ca": "null"
+    }
+  },
+  "GCP": {
+    "password": "mock-password",
+    "hostname": "10.160.68.75",
+    "port": 6378,
+    "uri": "rediss://:[email protected]:6378",
+    "cluster_mode": false,
+    "urls": {
+      "api_server": "https://api-backing-services.eu30.data.services.cloud.sap"
+    },
+    "tls": {
+      "server_ca": "null"
+    }
+  }
+}

test/__snapshots__/redis-adapter.test.js.snap

@@ -0,0 +1,58 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`redis-adapter test _createClientBase on CF | AWS-cluster 1`] = `
+[
+  {
+    "defaults": {
+      "password": "mock-password",
+      "pingInterval": 300000,
+      "socket": {
+        "host": "clustercfg.rg-0c94f0c1-db0a-495d-b385-4a44a87fc398.vwvwdz.euc1.cache.amazonaws.com",
+        "port": 3991,
+        "tls": true,
+      },
+    },
+    "rootNodes": [
+      {
+        "password": "mock-password",
+        "pingInterval": 300000,
+        "socket": {
+          "host": "clustercfg.rg-0c94f0c1-db0a-495d-b385-4a44a87fc398.vwvwdz.euc1.cache.amazonaws.com",
+          "port": 3991,
+          "tls": true,
+        },
+      },
+    ],
+  },
+]
+`;
+
+exports[`redis-adapter test _createClientBase on CF | AZURE 1`] = `
+[
+  {
+    "password": "mock-password",
+    "pingInterval": 300000,
+    "socket": {
+      "ca": "null",
+      "host": "redis-389395bc-9765-4d9a-ba6b-7252c136abab.redis.cache.windows.net",
+      "port": 6380,
+      "tls": true,
+    },
+  },
+]
+`;
+
+exports[`redis-adapter test _createClientBase on CF | GCP 1`] = `
+[
+  {
+    "password": "mock-password",
+    "pingInterval": 300000,
+    "socket": {
+      "host": "10.160.68.75",
+      "port": 6378,
+      "server_ca": "null",
+      "tls": true,
+    },
+  },
+]
+`;

test/redis-adapter.test.js

@@ -31,6 +31,7 @@ const mockClient = {
 const redis = require("@redis/client");
 jest.mock("@redis/client", () => ({
   createClient: jest.fn(() => mockClient),
+  createCluster: jest.fn(() => mockClient),
 }));
 
 const redisAdapter = require("../src/redis-adapter");
@@ -86,41 +87,23 @@ describe("redis-adapter test", () => {
     expect(loggerSpy.error).not.toHaveBeenCalled();
   });
 
-  test("_createClientBase on CF", async () => {
-    const mockUrl = "rediss://BAD_USERNAME:pwd@mockUrl";
-
-    envMock.isOnCf = true;
-    envMock.cfServiceCredentialsForLabel.mockReturnValueOnce({
-      cluster_mode: false,
-      uri: mockUrl,
-      hostname: "my-domain.com",
-      port: "1234",
-      password: "mock-password",
-      tls: { tlsOption: "tlsOption" },
-    });
-
-    const client = redisAdapter._._createClientBase();
-
-    expect(envMock.cfServiceCredentialsForLabel).toHaveBeenCalledTimes(1);
-    expect(envMock.cfServiceCredentialsForLabel).toHaveBeenCalledWith("redis-cache");
-    expect(redis.createClient).toHaveBeenCalledTimes(1);
-    expect(redis.createClient.mock.calls[0]).toMatchInlineSnapshot(`
-      [
-        {
-          "password": "mock-password",
-          "pingInterval": 300000,
-          "socket": {
-            "host": "my-domain.com",
-            "port": "1234",
-            "tls": true,
-            "tlsOption": "tlsOption",
-          },
-        },
-      ]
-    `);
-    expect(client).toBe(mockClient);
-    expect(loggerSpy.error).not.toHaveBeenCalled();
-  });
+  test.each(Object.entries(require("./__mocks__/mock-redis-credentials.json")))(
+    "_createClientBase on CF | %s",
+    async (_, credentials) => {
+      envMock.isOnCf = true;
+      envMock.cfServiceCredentialsForLabel.mockReturnValueOnce(credentials);
+
+      redisAdapter._._createClientBase();
+      const { cluster_mode: isCluster } = credentials;
+      const creator = isCluster ? redis.createCluster : redis.createClient;
+
+      expect(envMock.cfServiceCredentialsForLabel).toHaveBeenCalledTimes(1);
+      expect(envMock.cfServiceCredentialsForLabel).toHaveBeenCalledWith("redis-cache");
+      expect(creator).toHaveBeenCalledTimes(1);
+      expect(creator.mock.calls[0]).toMatchSnapshot();
+      expect(loggerSpy.error).not.toHaveBeenCalled();
+    }
+  );
 
   test("getMainClient", async () => {
     const client = await redisAdapter.getMainClient();