init throws for double invocation

Author: rlindner81

src/feature-toggles.js

@@ -1002,9 +1002,10 @@ class FeatureToggles {
    * @param {InitializeOptions}  [options]
    */
   async initializeFeatures(options) {
-    if (!this.__initializePromise) {
-      this.__initializePromise = this._initializeFeatures(options);
+    if (this.__initializePromise) {
+      throw new VError({ name: VERROR_CLUSTER_NAME }, "already initialized");
     }
+    this.__initializePromise = this._initializeFeatures(options);
     return await this.__initializePromise;
   }
 

test/integration-local/feature-toggles.integration.test.js

@@ -73,6 +73,13 @@ describe("local integration test", () => {
       },
     };
 
+    test("init throws for double invocation", async () => {
+      await toggles.initializeFeatures();
+      await expect(toggles.initializeFeatures()).rejects.toMatchInlineSnapshot(
+        `[FeatureTogglesError: already initialized]`
+      );
+    });
+
     test("init throws for non-existing filepaths", async () => {
       mockReadFile.mockImplementationOnce(fsActual.readFile);
       await expect(toggles.initializeFeatures({ configFile: "fantasy_name" })).rejects.toMatchInlineSnapshot(