Fb/fts scope callback (#55)

* wip 1

* wip 2

* use resolve

* pathlib

* there is no try

* trust that cds context exists

* keep it const

Author: rlindner81

cds-plugin.js

@@ -40,7 +40,7 @@ const _overwriteServiceAccessRoles = (envFeatureToggles) => {
   });
 };
 
-const _registerFeatureProvider = () => {
+const _registerFeatureProvider = (envFeatureToggles) => {
   if (!cds.env.requires?.toggles) {
     return;
   }
@@ -56,17 +56,20 @@ const _registerFeatureProvider = () => {
     return;
   }
 
+  const defaultFtsScopeCallback = (context) => ({ user: context.user?.id, tenant: context.tenant });
+  const ftsScopeCallback = envFeatureToggles?.ftsScopeCallback
+    ? require(pathlib.resolve(envFeatureToggles.ftsScopeCallback))
+    : defaultFtsScopeCallback;
+
   const _getReqFeatures = (req) => {
     if (doEnableHeaderFeatures && req.headers.features) {
       return req.headers.features;
     }
-    if (cds.context?.user?.features) {
+    if (cds.context.user?.features) {
       return cds.context.user.features;
     }
-    const user = cds.context?.user?.id;
-    const tenant = cds.context?.tenant;
     return cdsFeatures.reduce((result, [key, feature]) => {
-      if (toggles.getFeatureValue(key, { user, tenant })) {
+      if (toggles.getFeatureValue(key, ftsScopeCallback(cds.context, key))) {
         result.push(feature);
       }
       return result;
@@ -122,7 +125,7 @@ const activate = async () => {
     configAuto: ftsAutoConfig,
   });
 
-  _registerFeatureProvider();
+  _registerFeatureProvider(envFeatureToggles);
 };
 
 // NOTE: for sap/cds < 7.3.0 it was expected to export activate as function property, otherwise export the promise of

src/featureToggles.js

@@ -14,7 +14,7 @@
 // TODO locale for validation messages
 
 const { promisify } = require("util");
-const path = require("path");
+const pathlib = require("path");
 const { readFile } = require("fs");
 const VError = require("verror");
 const yaml = require("yaml");
@@ -31,7 +31,7 @@ const { Semaphore } = require("./shared/semaphore");
 const ENV_UNIQUE_NAME = process.env[ENV.UNIQUE_NAME];
 const DEFAULT_REDIS_CHANNEL = process.env[ENV.REDIS_CHANNEL] || "features";
 const DEFAULT_REDIS_KEY = process.env[ENV.REDIS_KEY] || "features";
-const DEFAULT_CONFIG_FILEPATH = path.join(process.cwd(), ".features.yaml");
+const DEFAULT_CONFIG_FILEPATH = pathlib.join(process.cwd(), ".features.yaml");
 const FEATURE_VALID_TYPES = ["string", "number", "boolean"];
 
 const SUPER_SCOPE_CACHE_SIZE_LIMIT = 15;
@@ -110,8 +110,7 @@ class FeatureToggles {
   // ========================================
 
   _processValidations(featureKey, validations, configFilepath) {
-    const workingDir = process.cwd();
-    const configDir = configFilepath ? path.dirname(configFilepath) : workingDir;
+    const configDir = configFilepath ? pathlib.dirname(configFilepath) : process.cwd();
 
     const validationsScopesMap = {};
     const validationsRegex = [];
@@ -130,15 +129,9 @@ class FeatureToggles {
       }
 
       if (validation.module) {
-        let modulePath = validation.module.replace("$CONFIG_DIR", configDir);
-        if (!path.isAbsolute(modulePath)) {
-          modulePath = path.join(workingDir, modulePath);
-        }
-        let validator = tryRequire(modulePath);
-
-        if (validation.call) {
-          validator = validator?.[validation.call];
-        }
+        const modulePath = validation.module.replace("$CONFIG_DIR", configDir);
+        const validatorModule = tryRequire(pathlib.resolve(modulePath));
+        const validator = validation.call ? validatorModule?.[validation.call] : validatorModule;
 
         const validatorType = typeof validator;
         if (validatorType === "function") {