Skip to content

Commit e102f08

Browse files
authored
better logging in feature service (#44)
1 parent e301aed commit e102f08

File tree

1 file changed

+25
-4
lines changed

1 file changed

+25
-4
lines changed

src/service/feature-service.js

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
"use strict";
22

3-
const cds = require("@sap/cds");
3+
const VError = require("verror");
44
const redis = require("../redisWrapper");
5+
const { Logger } = require("../logger");
56
const toggles = require("../");
67

7-
const COMPONENT_NAME = "featureService";
8+
const COMPONENT_NAME = "/FeatureService";
9+
const VERROR_CLUSTER_NAME = "FeatureServiceError";
810
const VALIDATION_ERROR_HTTP_CODE = 422;
911

12+
const logger = new Logger(COMPONENT_NAME);
13+
1014
const textFormat = (pattern, values) =>
1115
pattern.replace(/\{(\d+)}/g, (match, group) => {
1216
const index = parseInt(group);
@@ -32,7 +36,15 @@ const redisReadHandler = async (context) => {
3236
const result = toggles.getFeaturesInfos();
3337
context.reply(result);
3438
} catch (err) {
35-
cds.log(COMPONENT_NAME).error(err);
39+
logger.error(
40+
new VError(
41+
{
42+
name: VERROR_CLUSTER_NAME,
43+
cause: err,
44+
},
45+
"error during redis read"
46+
)
47+
);
3648
context.reject(500, { message: "caught unexpected error during redis read, check server logs" });
3749
}
3850
};
@@ -56,6 +68,7 @@ const redisReadHandler = async (context) => {
5668
*/
5769
const redisUpdateHandler = async (context) => {
5870
try {
71+
logger.info("redis update triggered with %O", context.data);
5972
const processEntry = async (entry) => {
6073
const { key, value, scope: scopeMap, options } = entry ?? {};
6174
const validationErrors = await toggles.changeFeatureValue(key, value, scopeMap, options);
@@ -75,7 +88,15 @@ const redisUpdateHandler = async (context) => {
7588
}
7689
context.reply();
7790
} catch (err) {
78-
cds.log(COMPONENT_NAME).error(err);
91+
logger.error(
92+
new VError(
93+
{
94+
name: VERROR_CLUSTER_NAME,
95+
cause: err,
96+
},
97+
"error during redis update"
98+
)
99+
);
79100
context.reject(500, { message: "caught unexpected error during redis update, check server logs" });
80101
}
81102
};

0 commit comments

Comments
 (0)