Fix(attachments): Improve Error Handling in Upload Lifecycle and Non-draft Upload Flow #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t operations Wrapped nonDraftHandler(), put(), and updateContentHandler() in try/catch blocks to ensure proper error propagation using req.error(...). • Ensured await super.put(...) is followed by error-safe logic in put(). • Invoked scanRequest() asynchronously with catch() to avoid crashing on malware scanner failures. • Prevented unhandled exceptions during file uploads and metadata updates in non-draft flow.
…istent CAP logging
…raftUpload
- Wrap srv.before("NEW"/"CREATE") handler with try/catch to log errors and reject on failure during attachment initialization
- Update nonDraftUpload function to handle errors gracefully, log failures, and reject to prevent unhandled exceptions
Improves robustness by preventing crashes due to unhandled errors in attachment upload lifecycle.
RoshniNaveenaS
requested review from
ashishjain14,
maheshsooryambylu,
rishikunnath2747,
dheerasameerk and
vibhutikumar07
There was a problem hiding this comment.
How the non-draft and draft scenarios be distinguishable from the usage perspective?
| try { | ||
| if (req?.content?.url?.endsWith("/content")) { | ||
| const attachmentID = req.content.url.match(attachmentIDRegex)[1]; | ||
| await AttachmentsSrv.nonDraftHandler(target, { ID: attachmentID, content: req.content }); |
There was a problem hiding this comment.
Doesn't the line 117 need to be executed only after the attachmentID is obtained ? I mean would there be a situation when AttachmentsSrv.nonDraftHandler is called when url.match is asynchronously being executed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #227 with better error handling, especially for non-draft attachment uploads:
• Added robust error handling and logging in attachment creation and upload handlers.
• Improved validation and rejection of invalid requests to prevent unhandled exceptions.
• Enhanced overall stability to avoid server crashes during file upload operations.
Also the documentation update is also covered as part of this PR
These changes improve reliability and make debugging easier.