Skip to content

Fix: Malware Scanning Refactor and Trigger Fix #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Fix: Malware Scanning Refactor and Trigger Fix #237

wants to merge 24 commits into from

Conversation

vlovini
Copy link
Collaborator

@vlovini vlovini commented Aug 29, 2025

This PR:

  • Refactors the implementation of Malware Scanner
  • Adds logs
  • Triggers the scanRequest using cds.spawn

Attention:

  • This PR is based on the branch fix/non-draft_mtls_upload
  • This PR still does not fix the issue of uploading - basically when doing a trigger, during the change of the status on the Attachment entity to Scanning, the request fails and the server crash and the server restarts. Filtered logs here
    filtered-logs.txt

@viniciuslora
feat: add try catch in stream function to catch error
27ea47e
@viniciuslora
fix: remove req.target.name for in case is not existing
f78633b
@viniciuslora
chore: remove await for scan request
b307ad7
@viniciuslora
chore: refactor malware scan code to be easier to make maintenance
b8327f1
@viniciuslora
chore: add log for update
7dae946
@viniciuslora
chore: add req tenant into get operation
eb71d9d
@viniciuslora
chore: move attachment service call to methods instead of passing as …
67c799e 
…parameters
@viniciuslora
chore: move attachment service outside try catch context
a1ec657
@viniciuslora
chore: add more logs
ace5552
@viniciuslora
chore: add more logs
59a7c74
@viniciuslora
chore: stringify attachmentsrv
085c921
@viniciuslora
chore: extract entity name from current entity
cadcab9
@viniciuslora
chore: add await to test async issues
683b6bc
@viniciuslora
chore: test removing promise from remoteScan
1e80bbb
@viniciuslora
chore: try moving to generic call from update
9865389
@viniciuslora
chore: use cds spawn to trigger request
6d4b2d8
@viniciuslora
chore: remove next
5f0a9a1
@viniciuslora
chore: add spawn for other put
191029a
@viniciuslora
chore: add next to do commit
b5214b9
@viniciuslora
chore: add logs
346abb9
@viniciuslora
chore: remove events handler for success/fail
d5ef872
@viniciuslora
chore: remove unecessary zip file
c0f86e9
Base automatically changed from fix/non-draft_mtls_upload to main September 9, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlovini @viniciuslora @eric-pSAP