Skip to content

Commit c63fb68

Browse files
[Fix] Removed redundant oauth2-configuration.redirect-uris and TENANT_HOST_PATTERN from the generated runtime-values.yaml (#74)
1 parent d78afc1 commit c63fb68

File tree

9 files changed

+10
-36
lines changed

9 files changed

+10
-36
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). The format is based on [Keep a Changelog](http://keepachangelog.com/).
44

5+
## Version 0.9.0 - 08-September-2025
6+
7+
### Fixed
8+
9+
- Removed redundant `oauth2-configuration.redirect-uris` and `TENANT_HOST_PATTERN` from the generated `runtime-values.yaml` file as it is now handled in the corresponding templates.
10+
511
## Version 0.8.0 - 20-August-2025
612

713
### Added

bin/cap-op-plugin.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -227,14 +227,6 @@ function updateWorkloadEnv(runtimeValuesYaml, valuesYaml, answerStruct) {
227227
if (workloadDetails?.jobDefinition?.type === 'TenantOperation' && answerStruct['hanaInstanceId']) {
228228
updateCdsConfigEnv(runtimeValuesYaml, workloadKey, 'jobDefinition', cdsConfigHana)
229229
}
230-
231-
if (workloadDetails?.deploymentDefinition?.type === 'Router') {
232-
const index = runtimeValuesYaml['workloads'][workloadKey]['deploymentDefinition']['env'].findIndex(e => e.name === 'TENANT_HOST_PATTERN')
233-
if (index > -1)
234-
runtimeValuesYaml['workloads'][workloadKey]['deploymentDefinition']['env'][index] = { name: 'TENANT_HOST_PATTERN', value: '^(.*).' + answerStruct["appName"] + '.' + answerStruct["clusterDomain"] }
235-
else
236-
runtimeValuesYaml['workloads'][workloadKey]['deploymentDefinition']['env'].push({ name: 'TENANT_HOST_PATTERN', value: '^(.*).' + answerStruct["appName"] + '.' + answerStruct["clusterDomain"] })
237-
}
238230
}
239231

240232
// remove workload definition where env is empty

files/runtime-values.yaml.hbs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ serviceInstances:
1616
{{xsuaaKeyName}}:
1717
parameters:
1818
xsappname: {{appName}}
19-
oauth2-configuration:
20-
redirect-uris:
21-
- "https://*{{appName}}.{{clusterDomain}}/**"
19+
2220
app:
2321
domains:
2422
primary: {{appName}}.{{clusterDomain}}

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@cap-js/cap-operator-plugin",
3-
"version": "0.8.0",
3+
"version": "0.9.0",
44
"description": "Add/Build Plugin for CAP Operator",
55
"homepage": "https://github.com/cap-js/cap-operator-plugin/blob/main/README.md",
66
"repository": {

test/files/expectedChart/runtime-values-svc.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ serviceInstances:
1111
xsuaa:
1212
parameters:
1313
xsappname: bkshop
14-
oauth2-configuration:
15-
redirect-uris:
16-
- https://*bkshop.c-abc.kyma.ondemand.com/**
1714
app:
1815
domains:
1916
primary: bkshop.c-abc.kyma.ondemand.com

test/files/expectedChart/runtime-values.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ serviceInstances:
1111
xsuaa:
1212
parameters:
1313
xsappname: bkshop
14-
oauth2-configuration:
15-
redirect-uris:
16-
- https://*bkshop.c-abc.kyma.ondemand.com/**
1714
app:
1815
domains:
1916
primary: bkshop.c-abc.kyma.ondemand.com
@@ -29,11 +26,6 @@ btp:
2926
imagePullSecrets:
3027
- regcred
3128
workloads:
32-
appRouter:
33-
deploymentDefinition:
34-
env:
35-
- name: TENANT_HOST_PATTERN
36-
value: ^(.*).bkshop.c-abc.kyma.ondemand.com
3729
server:
3830
deploymentDefinition:
3931
env:

test/files/expectedConfigurableTemplatesChart/runtime-values.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ serviceInstances:
1111
xsuaa:
1212
parameters:
1313
xsappname: bkshop
14-
oauth2-configuration:
15-
redirect-uris:
16-
- https://*bkshop.c-abc.kyma.ondemand.com/**
1714
app:
1815
domains:
1916
primary: bkshop.c-abc.kyma.ondemand.com

test/files/runtime-values-of-simple-chart.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ serviceInstances:
1111
xsuaa:
1212
parameters:
1313
xsappname: bkshop
14-
oauth2-configuration:
15-
redirect-uris:
16-
- https://*bkshop.c-abc.kyma.ondemand.com/**
1714
app:
1815
domains:
1916
primary: bkshop.c-abc.kyma.ondemand.com
@@ -29,11 +26,6 @@ btp:
2926
imagePullSecrets:
3027
- regcred
3128
workloads:
32-
appRouter:
33-
deploymentDefinition:
34-
env:
35-
- name: TENANT_HOST_PATTERN
36-
value: ^(.*).bkshop.c-abc.kyma.ondemand.com
3729
server:
3830
deploymentDefinition:
3931
env:

0 commit comments

Comments
 (0)