Skip to content

fix: use limit place holder with dedicated hint #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix: use limit place holder with dedicated hint #1260

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1120ad3
Start using limit place holder again with hints
BobdenOs Jun 30, 2025
fbe4201
Allow custom hints to overwrite default hints
BobdenOs Jun 30, 2025
68662e5
Check HANA version and limit_hint config for compatibility
BobdenOs Jul 15, 2025
9625481
Merge branch 'main' into perf/hana-limit-placeholder
BobdenOs Jul 15, 2025
9357366
Improve hints check with length
BobdenOs Jul 17, 2025
604adb7
Merge branch 'perf/hana-limit-placeholder' of https://github.com/cap-…
BobdenOs Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions hana/lib/HANAService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ class HANAService extends SQLService {

// REVISIT: add prepare options when param:true is used
let sqlScript = isLockQuery || isSimple ? sql : this.wrapTemporary(temporary, withclause, blobs)
const { hints } = query.SELECT
if (hints) sqlScript += ` WITH HINT (${hints.join(',')})`
const { hints = HANAVERSION <= 2 || this.options.limit_hint !== true ? null : ['prelimit_rule_with_sql_parameters'] } = query.SELECT
if (hints?.length) sqlScript += ` WITH HINT (${hints.join(',')})`
let rows
if (values?.length || blobs.length > 0 || isStream) {
const ps = await this.prepare(sqlScript, blobs.length)
Expand Down Expand Up @@ -931,11 +931,6 @@ SELECT ${mixing} FROM JSON_TABLE(SRC.JSON, '$' COLUMNS(${extraction}) ERROR ON E
})
}

limit({ rows, offset }) {
rows = { param: false, __proto__: rows }
return super.limit({ rows, offset })
}

where(xpr) {
xpr = { xpr, top: true }
const suffix = this.is_comparator(xpr)
Expand Down