Skip to content

feat: Enable client certificates #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Enable client certificates #1281

wants to merge 1 commit into from

Conversation

@Akatuoro
Copy link
Contributor

@Akatuoro Akatuoro commented Jul 21, 2025 •
edited
Loading

Behaviour should be implemented by @sap/hana-client.

This PR is to show what it takes to get it to run from a user perspective.

Enable x509 client certificates for hana connections. The order of key and certificate has to be switched so that it can be read by openssl inside @sap/hana-client.

To try it:

cds init bookshop --add tiny-sample,hana
cd bookshop
npm add @sap/hana-client

# cf login --sso
cds deploy -2 hana

# replace normal key (necessary for cds deploy) with x509 key
cf dsk -f bookshop-db bookshop-db-key --wait
cf csk bookshop-db bookshop-db-key -c '{"credential-type": "x509"}'

cds w --profile hybrid

Go to http://localhost:4004/odata/v4/catalog/Books

@Akatuoro Akatuoro changed the title Enable client certificates feat: Enable client certificates Jul 21, 2025
@johannes-vogel
Copy link
Contributor

johannes-vogel commented Aug 25, 2025

@Akatuoro I think we can close this one since SAP/node-hdb#262 got merged?
I think the same will also be released for @sap/hana-client

@Akatuoro
Copy link
Contributor Author

Akatuoro commented Aug 25, 2025

@Akatuoro I think we can close this one since SAP/node-hdb#262 got merged? I think the same will also be released for @sap/hana-client

@sap/hana-client is still open, looped you in to the mail thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@BobdenOs BobdenOs Awaiting requested review from BobdenOs BobdenOs is a code owner

@patricebender patricebender Awaiting requested review from patricebender patricebender is a code owner

@sjvans sjvans Awaiting requested review from sjvans sjvans is a code owner

@David-Kunz David-Kunz Awaiting requested review from David-Kunz David-Kunz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Akatuoro @johannes-vogel