Skip to content

Commit 27ebef1

Browse files
authored
chore: Prepare for cds9 (#179)
This is required for the tests in here to work with cds9. It is not required for actual use of the plugin at runtime, or in production.
1 parent 0bf5951 commit 27ebef1

File tree

4 files changed

+26
-14
lines changed

4 files changed

+26
-14
lines changed

tests/integration/fiori-draft-disabled.test.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ const cds = require("@sap/cds");
22
const bookshop = require("path").resolve(__dirname, "./../bookshop");
33
const { expect, data, POST, PATCH, DELETE } = cds.test(bookshop);
44

5+
// Enable locale fallback to simulate end user requests
6+
cds.env.features.locale_fallback = true
7+
58
jest.setTimeout(5 * 60 * 1000);
69

710
let adminService = null;
@@ -94,7 +97,7 @@ describe("change log draft disabled test", () => {
9497

9598
it("1.4 When the global switch is on, all changelogs should be retained after the root entity is deleted, and a changelog for the deletion operation should be generated", async () => {
9699
cds.env.requires["change-tracking"].preserveDeletes = true;
97-
100+
98101
cds.services.AdminService.entities.RootObject["@changelog"] = [
99102
{ "=": "title" }
100103
];
@@ -133,8 +136,8 @@ describe("change log draft disabled test", () => {
133136
const afterChanges = await adminService.run(SELECT.from(ChangeView));
134137
expect(afterChanges.length).to.equal(8);
135138

136-
const changelogCreated = afterChanges.filter(ele=> ele.modification === "Create");
137-
const changelogDeleted = afterChanges.filter(ele=> ele.modification === "Delete");
139+
const changelogCreated = afterChanges.filter(ele=> ele.modification === "Create");
140+
const changelogDeleted = afterChanges.filter(ele=> ele.modification === "Delete");
138141

139142
const compareAttributes = ['keys', 'attribute', 'entity', 'serviceEntity', 'parentKey', 'serviceEntityPath', 'valueDataType', 'objectID', 'parentObjectID', 'entityKey'];
140143

@@ -157,7 +160,7 @@ describe("change log draft disabled test", () => {
157160
cds.env.requires["change-tracking"].preserveDeletes = true;
158161
cds.services.AdminService.entities.Order.elements.netAmount["@changelog"] = true;
159162
cds.services.AdminService.entities.Order.elements.isUsed["@changelog"] = true;
160-
163+
161164
await POST(`/odata/v4/admin/Order`, {
162165
ID: "3e745e35-5974-4383-b60a-2f5c9bdd31ac",
163166
isUsed: false,
@@ -231,7 +234,7 @@ describe("change log draft disabled test", () => {
231234
valueChangedTo: ""
232235
},
233236
]);
234-
237+
235238
delete cds.services.AdminService.entities.Order.elements.netAmount["@changelog"];
236239
delete cds.services.AdminService.entities.Order.elements.isUsed["@changelog"];
237240
});
@@ -341,7 +344,7 @@ describe("change log draft disabled test", () => {
341344
});
342345

343346
const changes = await adminService.run(SELECT.from(ChangeView));
344-
347+
345348
expect(changes.length).to.equal(1);
346349
const change = changes[0];
347350
expect(change.attribute).to.equal("quantity");

tests/integration/fiori-draft-enabled.test.js

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ const bookshop = require("path").resolve(__dirname, "./../bookshop");
33
const { expect, data, POST, PATCH, DELETE } = cds.test(bookshop);
44
const { RequestSend } = require("../utils/api");
55

6+
// Enable locale fallback to simulate end user requests
7+
cds.env.features.locale_fallback = true
8+
69
jest.setTimeout(5 * 60 * 1000);
710

811
let adminService = null;
@@ -27,7 +30,7 @@ describe("change log integration test", () => {
2730
await data.reset();
2831
});
2932

30-
33+
3134
it("1.5 When the global switch is on, all changelogs should be retained after the root entity is deleted, and a changelog for the deletion operation should be generated", async () => {
3235
cds.env.requires["change-tracking"].preserveDeletes = true;
3336

@@ -63,14 +66,14 @@ describe("change log integration test", () => {
6366
true,
6467
);
6568
const beforeChanges = await adminService.run(SELECT.from(ChangeView));
66-
expect(beforeChanges.length > 0).to.be.true;
67-
69+
expect(beforeChanges.length > 0).to.be.true;
70+
6871
await DELETE(`/odata/v4/admin/RootEntity(ID=01234567-89ab-cdef-0123-987654fedcba,IsActiveEntity=true)`);
6972

7073
const afterChanges = await adminService.run(SELECT.from(ChangeView));
7174

72-
const changelogCreated = afterChanges.filter(ele=> ele.modification === "Create");
73-
const changelogDeleted = afterChanges.filter(ele=> ele.modification === "Delete");
75+
const changelogCreated = afterChanges.filter(ele=> ele.modification === "Create");
76+
const changelogDeleted = afterChanges.filter(ele=> ele.modification === "Delete");
7477

7578
const compareAttributes = ['keys', 'attribute', 'entity', 'serviceEntity', 'parentKey', 'serviceEntityPath', 'valueDataType', 'objectID', 'parentObjectID', 'entityKey'];
7679

@@ -279,7 +282,7 @@ describe("change log integration test", () => {
279282

280283
it("2.2 Child entity update - should log basic data type changes (ERP4SMEPREPWORKAPPPLAT-32 ERP4SMEPREPWORKAPPPLAT-613)", async () => {
281284
cds.services.AdminService.entities.Books.elements.price["@changelog"] = true;
282-
285+
283286
const action = PATCH.bind({}, `/odata/v4/admin/Books(ID=9d703c23-54a8-4eff-81c1-cdce6b8376b1,IsActiveEntity=false)`, {
284287
title: "new title",
285288
author_ID: "47f97f40-4f41-488a-b10b-a5725e762d5e",
@@ -549,7 +552,7 @@ describe("change log integration test", () => {
549552
await utils.apiAction("admin", "BookStores", "64625905-c234-4d0d-9bc1-283ee8946770", "AdminService", action);
550553

551554
const changes = await adminService.run(SELECT.from(ChangeView));
552-
555+
553556
expect(changes.length).to.equal(1);
554557
const change = changes[0];
555558
expect(change.attribute).to.equal("title");
@@ -1038,7 +1041,7 @@ describe("change log integration test", () => {
10381041

10391042
it("7.1 Annotate fields from chained associated entities as objectID (ERP4SMEPREPWORKAPPPLAT-993)", async () => {
10401043
cds.services.AdminService.entities.BookStores["@changelog"].push({ "=": "city.name" })
1041-
1044+
10421045
const createBookStoresAction = POST.bind({}, `/odata/v4/admin/BookStores`, {
10431046
ID: "9d703c23-54a8-4eff-81c1-cdce6b6587c4",
10441047
name: "new name",

tests/integration/service-api.test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ const cds = require("@sap/cds");
22
const bookshop = require("path").resolve(__dirname, "./../bookshop");
33
const { expect, data } = cds.test(bookshop);
44

5+
// Enable locale fallback to simulate end user requests
6+
cds.env.features.locale_fallback = true
7+
58
jest.setTimeout(5 * 60 * 1000);
69

710
let adminService = null;

tests/unit/util.test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ const { expect } = cds.test
33
const templateProcessor = require("../../lib/template-processor");
44
const { getEntityByContextPath } = require("../../lib/entity-helper");
55

6+
// Enable locale fallback to simulate end user requests
7+
cds.env.features.locale_fallback = true
8+
69
const _processorFn = (changeMap) => {
710
return ({ row, key, element }) => {
811
if (!row || !key || !element) {

0 commit comments

Comments
 (0)