Valid ObjectID for simultaneous creation of parent/child (#40)

Author: mnkiefer

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## Version 1.0.3 - TBD
+
+### Changed
+
+- Support cases where parent/child entries are created simultaneously.
+
 ## Version 1.0.2 - 31.10.23
 
 ### Changed

lib/entity-helper.js

@@ -85,7 +85,9 @@ async function getObjectId (entityName, fields, curObj) {
         if (IDval) try {
           // REVISIT: This always reads all elements -> should read required ones only!
           let ID = assoc.keys?.[0]?.ref[0] || 'ID'
-          _db_data = await SELECT.one.from(assoc._target).where({[ID]: IDval}) || {}
+          // When parent/child nodes are created simultaneously, data is taken from draft table
+          _db_data = await SELECT.one.from(assoc._target).where({[ID]: IDval}) ||
+            await SELECT.one.from(`${assoc._target}.drafts`).where({[ID]: IDval}) || {}
         } catch (e) {
           LOG.error("Failed to generate object Id for an association entity.", e)
           throw new Error("Failed to generate object Id for an association entity.", e)

tests/integration/fiori-draft-enabled.test.js

@@ -806,6 +806,43 @@ describe("change log integration test", () => {
         const deleteTitleChange = deleteTitleChanges[0];
         expect(deleteTitleChange.objectID).to.equal("new title, In Preparation, France");
 
+        // Check object ID "bookStore.city.country.countryName.code" when creating BookStores/Books
+        // (parent/child) at the same time.
+        cds.services.AdminService.entities.Books["@changelog"] = [
+            { "=": "bookStore.city.country.countryName.code" },
+        ];
+
+        const createBooksAndBookStoresAction = POST.bind({}, `/odata/v4/admin/BookStores`, {
+            ID: "48268451-8552-42a6-a3d7-67564be86634",
+            city_ID: "60b4c55d-ec87-4edc-84cb-2e4ecd60de48",
+            books: [
+                {
+                    ID: "12ed5dd8-d45b-11ed-afa1-1942bd119007",
+                    title: "New title",
+                },
+            ],
+        });
+
+        await utils.apiAction(
+            "admin",
+            "BookStores",
+            "48268451-8552-42a6-a3d7-67564be86634",
+            "AdminService",
+            createBooksAndBookStoresAction,
+            true,
+        );
+
+        const createBooksAndBookStoresChanges = await adminService.run(
+            SELECT.from(ChangeView).where({
+                entity: "sap.capire.bookshop.Books",
+                attribute: "title",
+                modification: "create",
+            }),
+        );
+        expect(createBooksAndBookStoresChanges.length).to.equal(1);
+        const createBooksAndBookStoresChange = createBooksAndBookStoresChanges[0];
+        expect(createBooksAndBookStoresChange.objectID).to.equal("USA");
+
         cds.services.AdminService.entities.Books["@changelog"] = [
             { "=": "title" },
             { "=": "author.name.firstName" },