Fix comments

Author: ipaunov

lib/notifications.js

@@ -1,5 +1,5 @@
 const { buildCsrfHeaders } = require("@sap-cloud-sdk/core");
-const { getNotificationDestination, executeRequest, createNotification } = require("./utils");
+const { getNotificationDestination, executeRequest, buildNotification } = require("./utils");
 
 const NOTIFICATIONS_DESTINATION_NAME = cds.env.requires.notifications?.destination ?? "SAP_Notifications";
 const NOTIFICATIONS_API_ENDPOINT = "v2/Notification.svc";
@@ -10,7 +10,7 @@ async function postNotification() {
     url: NOTIFICATIONS_API_ENDPOINT,
   });
 
-  const notification = createNotification(arguments);
+  const notification = buildNotification(arguments);
 
   if (notification) {
     return (await executeRequest("post", `${NOTIFICATIONS_API_ENDPOINT}/Notifications`, notification, notifServiceDest, csrfHeaders)).data.d;

lib/utils.js

@@ -72,7 +72,7 @@ async function executeRequest(httpMethod, targetUrl, payload, notifServiceDest,
   return response;
 }
 
-function createDefaultNotification(
+function buildDefaultNotification(
   recipients,
   priority,
   title,
@@ -104,7 +104,7 @@ function createDefaultNotification(
   };
 }
 
-function createNotification(passedArguments) {
+function buildNotification(passedArguments) {
   let notification;
   if (passedArguments.length == 1 && typeof passedArguments[0] === "object" && !Array.isArray(passedArguments[0])) {
     notification = passedArguments[0];
@@ -119,7 +119,7 @@ function createNotification(passedArguments) {
       return;
     }
 
-    notification = createDefaultNotification(
+    notification = buildDefaultNotification(
       recipients,
       priority,
       title,
@@ -139,5 +139,5 @@ module.exports = {
   getPrefix,
   getNotificationTypesKeyWithPrefix,
   executeRequest,
-  createNotification
+  buildNotification
 };

srv/notifyToConsole.js

@@ -1,5 +1,5 @@
 const NotificationService = require('./service');
-const { createNotification, readFile, doesKeyExist } = require("./../lib/utils");
+const { buildNotification, readFile, doesKeyExist } = require("./../lib/utils");
 const { createNotificationTypesMap } = require("./../lib/notificationTypes");
 
 module.exports = class NotifyToConsole extends NotificationService {
@@ -10,13 +10,12 @@ module.exports = class NotifyToConsole extends NotificationService {
 
   notify() {
 
-    const notification = createNotification(arguments);
+    const notification = buildNotification(arguments);
 
     if (notification) {
       console.log(`SAP Alert Notification service notification: ${JSON.stringify(notification, null, 2)}`);
 
-      const typesFile = readFile(cds.env.requires.notifications.types);
-      const existingTypes = createNotificationTypesMap(typesFile);
+      const existingTypes = cds.notifications.local.types;
 
       if (!doesKeyExist(existingTypes, notification["NotificationTypeKey"])) {
         console.log(`Notification Type ${notification["NotificationTypeKey"]} is not in the notification types file`);