Add additional tests for notifyToRest and utils (#28)

* Add additional tests for notifyToRest

* Additional tests

Author: simeonPetkov96

lib/utils.js

@@ -2,7 +2,6 @@ const { existsSync, readFileSync } = require('fs');
 const { basename } = require('path');
 const cds = require("@sap/cds");
 const LOG = cds.log('notifications');
-const { executeHttpRequest } = require("@sap-cloud-sdk/http-client");
 const { getDestination } = require("@sap-cloud-sdk/connectivity");
 const PRIORITIES = ["LOW", "NEUTRAL", "MEDIUM", "HIGH"];
 
@@ -23,12 +22,12 @@ const messages = {
 };
 
 function validateNotificationTypes(notificationTypes) {
-  notificationTypes.forEach((notificationType) => {
+  for(notificationType of notificationTypes){
     if (!("NotificationTypeKey" in notificationType)) {
       LOG._warn && LOG.warn(messages.INVALID_NOTIFICATION_TYPES);
       return false;
     }
-  });
+  }
 
   return true;
 }
@@ -128,22 +127,6 @@ function getNotificationTypesKeyWithPrefix(notificationTypeKey) {
   return `${prefix}/${notificationTypeKey}`;
 }
 
-async function executeRequest(httpMethod, targetUrl, payload, notificationDestination, csrfHeaders) {
-  let response = {};
-  try {
-    response = await executeHttpRequest(notificationDestination, {
-      url: targetUrl,
-      method: httpMethod,
-      data: payload,
-      headers: csrfHeaders,
-    });
-  } catch (e) {
-    console.log(e);
-    response = e.response.data;
-  }
-  return response;
-}
-
 function buildDefaultNotification(
   recipients,
   priority = "NEUTRAL",
@@ -255,6 +238,5 @@ module.exports = {
   getNotificationDestination,
   getPrefix,
   getNotificationTypesKeyWithPrefix,
-  executeRequest,
   buildNotification
 };

srv/notifyToRest.js

@@ -1,29 +1,20 @@
-const NotificationService = require('./service');
+const NotificationService = require("./service");
 const { buildNotification } = require("../lib/utils");
-const { postNotification } = require('../lib/notifications');
+const { postNotification } = require("../lib/notifications");
 
 module.exports = class NotifyToRest extends NotificationService {
   async init() {
-
     // call NotificationService's init
     await super.init();
 
-    this.on('postNotificationEvent', async function(req) {
-      const { data } = req;
-
-      try {
-        await postNotification(data);
-      } catch (err) {
-        throw err;
-      }
-    });
+    this.on("postNotificationEvent", async (req) => await postNotification(req.data));
   }
 
   async notify(notificationData) {
     const notification = buildNotification(notificationData);
 
     if (notification) {
-      await this.emit({ event: 'postNotificationEvent', data: notification });
+      await this.emit({ event: "postNotificationEvent", data: notification });
     }
   }
-}
+};