Fix comments

Author: ipaunov

lib/utils.js

@@ -9,7 +9,7 @@ const messages = {
   TYPES_FILE_NOT_EXISTS: "Notification Types file path is incorrect.",
   INVALID_NOTIFICATION_TYPES: "Notification Types must contain the following key: 'NotificationTypeKey'.",
   DESTINATION_NOT_FOUND: "Failed to get destination: ",
-  MANDATORY_PARAMETER_NOT_PASSED_FOR_DEFAULT_NOTIFICATION: "Recipients, priority and title are mandatory parameters",
+  MANDATORY_PARAMETER_NOT_PASSED_FOR_DEFAULT_NOTIFICATION: "Recipients and title are mandatory parameters",
   MANDATORY_PARAMETER_NOT_PASSED_FOR_CUSTOM_NOTIFICATION: "Recipients, type are mandatory parameters",
   RECIPIENTS_IS_NOT_ARRAY: "Recipients is not an array or it is empty",
   TITLE_IS_NOT_STRING: "Title is not a string",
@@ -32,7 +32,7 @@ function validateNotificationTypes(notificationTypes) {
 }
 
 function validateDefaultNotifyParameters(recipients, priority, title, description) {
-  if (!recipients || !priority || !title) {
+  if (!recipients || !title) {
     console.log(messages.MANDATORY_PARAMETER_NOT_PASSED_FOR_DEFAULT_NOTIFICATION);
     return false;
   }
@@ -47,12 +47,12 @@ function validateDefaultNotifyParameters(recipients, priority, title, descriptio
     return false;
   }
 
-  if (!PRIORITIES.includes(priority)) {
+  if (priority && !PRIORITIES.includes(priority.toUpperCase())) {
     console.log(`Invalid priority ${priority}. Allowed priorities are LOW, NEUTRAL, MEDIUM, HIGH`);
     return false;
   }
 
-  if (description !== undefined && typeof description !== "string") {
+  if (description && typeof description !== "string") {
     console.log(messages.DESCRIPTION_IS_NOT_STRING);
     return false;
   }
@@ -71,22 +71,22 @@ function validateCustomNotifyParameters(type, recipients, properties, navigation
     return false;
   }
 
-  if (priority === undefined || !PRIORITIES.includes(priority)) {
+  if (priority && !PRIORITIES.includes(priority.toUpperCase())) {
     console.log(`Invalid priority ${priority}. Allowed priorities are LOW, NEUTRAL, MEDIUM, HIGH`);
     return false;
   }
 
-  if (properties !== undefined && !Array.isArray(properties)) {
+  if (properties && !Array.isArray(properties)) {
     console.log(messages.PROPERTIES_IS_NOT_OBJECT);
     return false;
   }
 
-  if (navigation !== undefined && typeof navigation !== "object") {
+  if (navigation && typeof navigation !== "object") {
     console.log(messages.NAVIGATION_IS_NOT_OBJECT);
     return false;
   }
 
-  if (payload !== undefined && typeof payload !== "object") {
+  if (payload && typeof payload !== "object") {
     console.log(messages.PAYLOAD_IS_NOT_OBJECT);
     return false;
   }
@@ -144,7 +144,7 @@ async function executeRequest(httpMethod, targetUrl, payload, notificationDestin
 
 function buildDefaultNotification(
   recipients,
-  priority,
+  priority = "NEUTRAL",
   title,
   description = ""
 ) {
@@ -183,7 +183,7 @@ function buildCustomNotification(notificationData) {
     NotificationTypeVersion: notificationData["payload"] ? notificationData["payload"]["NotificationTypeVersion"] : "1",
     NavigationTargetAction: notificationData["navigation"] ? notificationData["navigation"]["NavigationTargetAction"] : undefined,
     NavigationTargetObject: notificationData["navigation"] ? notificationData["navigation"]["NavigationTargetObject"] : undefined,
-    Priority: notificationData["priority"] ? notificationData["priority"] : "MEDIUM",
+    Priority: notificationData["priority"] ? notificationData["priority"] : "NEUTRAL",
     ProviderId: notificationData["payload"] ? notificationData["payload"]["ProviderId"] : undefined,
     ActorId: notificationData["payload"] ? notificationData["payload"]["ActorId"] : undefined,
     ActorDisplayText: notificationData["payload"] ? notificationData["payload"]["ActorDisplayText"] : undefined,
@@ -239,4 +239,3 @@ module.exports = {
   executeRequest,
   buildNotification
 };
-

srv/notifyToConsole.js

@@ -10,7 +10,7 @@ module.exports = class NotifyToConsole extends NotificationService {
 
   notify() {
 
-    const notification = buildNotification(arguments);
+    const notification = buildNotification(arguments[0]);
 
     if (notification) {
       console.log(`SAP Alert Notification service notification: ${JSON.stringify(notification, null, 2)}`);