Merge pull request #47 from cap-js/fix_code_smells

Fix code smells

Author: ipaunov

CHANGELOG.md

@@ -9,4 +9,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
 ### Added
 
-- Initial release
+- Initial release
+
+## Version 0.2.0
+
+### Fixed
+
+- Fixed code smells and Dependabot alerts

README.md

@@ -2,7 +2,7 @@
 
 # Notifications Plugin
 
-The `@cap-js/notifications` package is a [CDS plugin](https://cap.cloud.sap/docs/node.js/cds-plugins#cds-plugin-packages) that provides support for publishing business notifications.
+The `@cap-js/notifications` package is a [CDS plugin](https://cap.cloud.sap/docs/node.js/cds-plugins#cds-plugin-packages) that provides support for publishing business notifications in SAP Build WorkZone.
 
 ### Table of Contents
 
@@ -109,7 +109,7 @@ As a pre-requisite to publish the notification, you need to have a [destination]
 
 #### Integrate with SAP Build Work Zone
 
-Once application is deployed and [integrated with SAP Build Work Zone](https://github.com/cap-js/calesi/tree/main/samples/notifications), you can see the notification under fiori notifications icon!
+Once application is deployed and integrated with SAP Build Work Zone, you can see the notification under fiori notifications icon!
 
 <img width="1300" alt="Sample Application Demo" style="border-radius:0.5rem;" src="_assets/incidentsNotificationDemo.gif">
 

cds-plugin.js

@@ -2,12 +2,10 @@ const cds = require("@sap/cds/lib");
 
 if (cds.cli.command === "build") {
   // register build plugin
-  const build = require('@sap/cds-dk/lib/build')
-  build.register('notifications', {
-    impl: '@cap-js/notifications/lib/build',
-    description: 'Notifications build plugin',
-    taskDefaults: { src: cds.env.folders.srv }
-  })
+  cds.build?.register?.('notifications', { 
+      impl: '@cap-js/notifications/lib/build',
+      taskDefaults: { src: cds.env.folders.srv }
+  });
 }
 
 else cds.once("served", async () => {

lib/build.js

@@ -1,5 +1,5 @@
 const cds = require('@sap/cds')
-const { BuildPlugin } = require('@sap/cds-dk/lib/build')
+const { BuildPlugin } = cds.build
 
 const { copy, exists, path } = cds.utils
 
@@ -11,7 +11,7 @@ module.exports = class NotificationsBuildPlugin extends BuildPlugin {
   }
 
   async build() {
-    if(exists(cds.env.requires.notifications.types)) {
+    if (exists(cds.env.requires.notifications?.types)) {
       const fileName = path.basename(cds.env.requires.notifications.types);
       await copy(cds.env.requires.notifications.types).to(path.join(this.task.dest, fileName));
     }