Merge pull request #297 from cap-js/csn-interop-fix-localized

Remove association "localized" from interop CSN

Author: stewsk

__tests__/__snapshots__/ord.e2e.test.js.snap

@@ -1334,38 +1334,6 @@ exports[`Tests for Data Product definition Check interop CSN content 1`] = `
         "genre_ID": {
           "type": "cds.Integer",
         },
-        "localized": {
-          "on": [
-            {
-              "ref": [
-                "localized",
-                "ID",
-              ],
-            },
-            "=",
-            {
-              "ref": [
-                "ID",
-              ],
-            },
-            "and",
-            {
-              "ref": [
-                "localized",
-                "locale",
-              ],
-            },
-            "=",
-            {
-              "ref": [
-                "$user",
-                "locale",
-              ],
-            },
-          ],
-          "target": "sap.capdpprod.DPBooks.v1.Books.texts",
-          "type": "cds.Association",
-        },
         "modifiedAt": {
           "@EndUserText.label": "{i18n>ChangedAt}",
           "@UI.ExcludeFromNavigationContext": true,
@@ -1483,38 +1451,6 @@ exports[`Tests for Data Product definition Check interop CSN content 1`] = `
           "length": 1000,
           "type": "cds.String",
         },
-        "localized": {
-          "on": [
-            {
-              "ref": [
-                "localized",
-                "code",
-              ],
-            },
-            "=",
-            {
-              "ref": [
-                "code",
-              ],
-            },
-            "and",
-            {
-              "ref": [
-                "localized",
-                "locale",
-              ],
-            },
-            "=",
-            {
-              "ref": [
-                "$user",
-                "locale",
-              ],
-            },
-          ],
-          "target": "sap.capdpprod.DPBooks.v1.Currencies.texts",
-          "type": "cds.Association",
-        },
         "minorUnit": {
           "@EndUserText.label": "{i18n>CurrencyMinorUnit}",
           "type": "cds.Int16",
@@ -1628,38 +1564,6 @@ exports[`Tests for Data Product definition Check interop CSN content 1`] = `
           "length": 1000,
           "type": "cds.String",
         },
-        "localized": {
-          "on": [
-            {
-              "ref": [
-                "localized",
-                "ID",
-              ],
-            },
-            "=",
-            {
-              "ref": [
-                "ID",
-              ],
-            },
-            "and",
-            {
-              "ref": [
-                "localized",
-                "locale",
-              ],
-            },
-            "=",
-            {
-              "ref": [
-                "$user",
-                "locale",
-              ],
-            },
-          ],
-          "target": "sap.capdpprod.DPBooks.v1.Genres.texts",
-          "type": "cds.Association",
-        },
         "name": {
           "@EndUserText.label": "{i18n>Name}",
           "length": 255,

lib/interopCsn.js

@@ -4,6 +4,7 @@ const localize = require("@sap/cds/lib/i18n/localize");
 function interopCSN(csn) {
     if (typeof csn != "object" || csn === null) return csn; // handle non-object inputs early
     add_i18n_texts(csn);
+    remove_localized_assoc(csn);
     map_annotations(csn);
     add_meta_info(csn);
     return csn;
@@ -61,6 +62,30 @@ function add_i18n_texts(csn) {
     }
 }
 
+//
+// remove association "localized" for localized texts
+//
+// The "localized" association for localized elements contains a reference to $user.locale
+// and is specific to the CAP. It needs to be removed from the interop CSN.
+//
+function remove_localized_assoc(csn) {
+    // how to detect "localized" association?
+    // - name is "localized"
+    // - type is "cds.Association"
+    // - target name is source name + ".texts"
+    // - there is an ON condition 
+    for (let n1 in csn.definitions) {
+        let def = csn.definitions[n1];
+        if (def.kind === "entity")
+            for (let n2 in def.elements) {
+                let el = def.elements[n2];
+                if (n2 === "localized" && el.type === "cds.Association" && el.target === `${n1}.texts` && el.on) {
+                    delete def.elements[n2];
+                }
+            }
+    }
+}
+
 //
 // annotation mapping/replacement
 //