Skip to content

Commit 2bdec42

Browse files
committed
feat: update serializer
+ upgrade log4j version
1 parent 060d204 commit 2bdec42

File tree

10 files changed

+100
-36
lines changed

10 files changed

+100
-36
lines changed

sdk-component/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<properties>
3434
<okhttp.version>4.9.1</okhttp.version>
3535
<kotlin-stdlib.version>1.4.10</kotlin-stdlib.version>
36-
<log4j.version>2.14.1</log4j.version>
36+
<log4j.version>2.15.0</log4j.version>
3737
<logback.version>1.2.3</logback.version>
3838
</properties>
3939

sdk-component/src/main/java/group/rxcloud/capa/component/log/CapaLogbackAppenderAgent.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
* The agent of the logback impl.
2525
*/
2626
public class CapaLogbackAppenderAgent extends UnsynchronizedAppenderBase<ILoggingEvent> {
27+
2728
/**
2829
* The log component type.
2930
*/

sdk-component/src/test/java/group/rxcloud/capa/component/configstore/TestObjectSerializer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
package group.rxcloud.capa.component.configstore;
1818

1919
import group.rxcloud.capa.infrastructure.serializer.CapaObjectSerializer;
20-
import group.rxcloud.capa.infrastructure.serializer.ObjectSerializer;
20+
import group.rxcloud.capa.infrastructure.serializer.ExtensionObjectSerializer;
2121

2222
/**
2323
* serializer/deserializer for request/response objects used in tests only
2424
*/
25-
public class TestObjectSerializer extends ObjectSerializer implements CapaObjectSerializer {
25+
public class TestObjectSerializer extends ExtensionObjectSerializer implements CapaObjectSerializer {
2626

2727
/**
2828
* {@inheritDoc}

sdk-component/src/test/java/group/rxcloud/capa/component/http/CapaHttpBuilderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import group.rxcloud.capa.infrastructure.serializer.CapaObjectSerializer;
2020
import group.rxcloud.capa.infrastructure.serializer.DefaultObjectSerializer;
21-
import group.rxcloud.capa.infrastructure.serializer.ObjectSerializer;
21+
import group.rxcloud.capa.infrastructure.serializer.ExtensionObjectSerializer;
2222
import org.junit.jupiter.api.Assertions;
2323
import org.junit.jupiter.api.Test;
2424

@@ -53,7 +53,7 @@ public void testBuild_Success() {
5353
/**
5454
* serializer/deserializer for request/response objects used in tests only
5555
*/
56-
private class TestObjectSerializer extends ObjectSerializer implements CapaObjectSerializer {
56+
private class TestObjectSerializer extends ExtensionObjectSerializer implements CapaObjectSerializer {
5757

5858
/**
5959
* {@inheritDoc}
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
/*
2+
* Copyright 2021 Layotto Authors
3+
* Licensed under the Apache License, Version 2.0 (the "License");
4+
* you may not use this file except in compliance with the License.
5+
* You may obtain a copy of the License at
6+
*
7+
* http://www.apache.org/licenses/LICENSE-2.0
8+
*
9+
* Unless required by applicable law or agreed to in writing, software
10+
* distributed under the License is distributed on an "AS IS" BASIS,
11+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
* See the License for the specific language governing permissions and
13+
* limitations under the License.
14+
*/
15+
package group.rxcloud.capa.infrastructure.serializer;
16+
17+
import group.rxcloud.cloudruntimes.utils.TypeRef;
18+
19+
import java.io.IOException;
20+
21+
public abstract class AbstractObjectSerializer implements CapaObjectSerializer {
22+
23+
/**
24+
* {@inheritDoc}
25+
*/
26+
@Override
27+
public byte[] serialize(Object o) throws IOException {
28+
if (o == null) {
29+
return null;
30+
}
31+
if (o instanceof byte[]) {
32+
return (byte[]) o;
33+
}
34+
if (o instanceof String) {
35+
return ((String) o).getBytes();
36+
}
37+
38+
return doSerialize(o);
39+
}
40+
41+
protected abstract byte[] doSerialize(Object o) throws IOException;
42+
43+
/**
44+
* {@inheritDoc}
45+
*/
46+
@Override
47+
public <T> T deserialize(byte[] data, TypeRef<T> type) throws IOException {
48+
Class<T> clazz = (Class<T>) type.getType();
49+
if (data == null) {
50+
return null;
51+
}
52+
if (clazz == byte[].class) {
53+
return (T) data;
54+
}
55+
if (clazz == String.class) {
56+
return (T) new String(data);
57+
}
58+
59+
return doDeserialize(data, type);
60+
}
61+
62+
protected abstract <T> T doDeserialize(byte[] data, TypeRef<T> type) throws IOException;
63+
}

sdk-infrastructure/src/main/java/group/rxcloud/capa/infrastructure/serializer/DefaultObjectSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
/**
2525
* Default serializer/deserializer for request/response objects.
2626
*/
27-
public class DefaultObjectSerializer extends ObjectSerializer implements CapaObjectSerializer {
27+
public class DefaultObjectSerializer extends ExtensionObjectSerializer implements CapaObjectSerializer {
2828

2929
/**
3030
* {@inheritDoc}

sdk-infrastructure/src/main/java/group/rxcloud/capa/infrastructure/serializer/ObjectSerializer.java renamed to sdk-infrastructure/src/main/java/group/rxcloud/capa/infrastructure/serializer/ExtensionObjectSerializer.java

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
/**
3232
* Serializes and deserializes an internal object.
3333
*/
34-
public class ObjectSerializer {
34+
public abstract class ExtensionObjectSerializer extends AbstractObjectSerializer {
3535

3636
/**
3737
* Shared Json serializer/deserializer as per Jackson's documentation.
@@ -44,7 +44,7 @@ public class ObjectSerializer {
4444
/**
4545
* Default constructor to avoid class from being instantiated outside package but still inherited.
4646
*/
47-
protected ObjectSerializer() {
47+
protected ExtensionObjectSerializer() {
4848
}
4949

5050
/**
@@ -55,33 +55,31 @@ protected ObjectMapper getObjectMapper() {
5555
}
5656

5757
/**
58-
* Serializes a given state object into byte array.
58+
* Serializes a given object into byte array.
5959
*
60-
* @param state State object to be serialized.
60+
* @param o object to be serialized.
6161
* @return Array of bytes[] with the serialized content.
62-
* @throws IOException In case state cannot be serialized.
62+
* @throws IOException In case o cannot be serialized.
6363
*/
64-
public byte[] serialize(Object state) throws IOException {
65-
if (state == null) {
64+
@Override
65+
public byte[] doSerialize(Object o) throws IOException {
66+
if (o == null) {
6667
return null;
6768
}
68-
69-
if (state.getClass() == Void.class) {
69+
if (o.getClass() == Void.class) {
7070
return null;
7171
}
72-
7372
// Have this check here to be consistent with deserialization (see deserialize() method below).
74-
if (state instanceof byte[]) {
75-
return (byte[]) state;
73+
if (o instanceof byte[]) {
74+
return (byte[]) o;
7675
}
77-
7876
// Proto buffer class is serialized directly.
79-
if (state instanceof MessageLite) {
80-
return ((MessageLite) state).toByteArray();
77+
if (o instanceof MessageLite) {
78+
return ((MessageLite) o).toByteArray();
8179
}
8280

8381
// Not string, not primitive, so it is a complex type: we use JSON for that.
84-
return getObjectMapper().writeValueAsBytes(state);
82+
return getObjectMapper().writeValueAsBytes(o);
8583
}
8684

8785
/**
@@ -93,8 +91,9 @@ public byte[] serialize(Object state) throws IOException {
9391
* @return Object of type T.
9492
* @throws IOException In case content cannot be deserialized.
9593
*/
96-
public <T> T deserialize(byte[] content, TypeRef<T> type) throws IOException {
97-
return deserialize(content, getObjectMapper().constructType(type.getType()));
94+
@Override
95+
public <T> T doDeserialize(byte[] content, TypeRef<T> type) throws IOException {
96+
return doDeserialize(content, getObjectMapper().constructType(type.getType()));
9897
}
9998

10099
/**
@@ -106,11 +105,11 @@ public <T> T deserialize(byte[] content, TypeRef<T> type) throws IOException {
106105
* @return Object of type T.
107106
* @throws IOException In case content cannot be deserialized.
108107
*/
109-
public <T> T deserialize(byte[] content, Class<T> clazz) throws IOException {
110-
return deserialize(content, getObjectMapper().constructType(clazz));
108+
public <T> T doDeserialize(byte[] content, Class<T> clazz) throws IOException {
109+
return doDeserialize(content, getObjectMapper().constructType(clazz));
111110
}
112111

113-
private <T> T deserialize(byte[] content, JavaType javaType) throws IOException {
112+
private <T> T doDeserialize(byte[] content, JavaType javaType) throws IOException {
114113
if ((javaType == null) || javaType.isTypeOrSubTypeOf(Void.class)) {
115114
return null;
116115
}

sdk-spi/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<name>capa-sdk-spi</name>
3232

3333
<properties>
34-
<log4j.version>2.14.1</log4j.version>
34+
<log4j.version>2.15.0</log4j.version>
3535
<logback.version>1.2.3</logback.version>
3636
</properties>
3737

sdk-spi/src/test/java/group/rxcloud/capa/spi/http/CapaSerializeHttpSpiTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import group.rxcloud.capa.infrastructure.exceptions.CapaException;
2222
import group.rxcloud.capa.infrastructure.serializer.CapaObjectSerializer;
2323
import group.rxcloud.capa.infrastructure.serializer.DefaultObjectSerializer;
24-
import group.rxcloud.capa.infrastructure.serializer.ObjectSerializer;
24+
import group.rxcloud.capa.infrastructure.serializer.ExtensionObjectSerializer;
2525
import group.rxcloud.capa.spi.http.config.RpcServiceOptions;
2626
import group.rxcloud.cloudruntimes.utils.TypeRef;
2727
import okhttp3.Headers;
@@ -223,7 +223,7 @@ public void testDoInvokeApi_Success() throws ExecutionException, InterruptedExce
223223
/**
224224
* serializer/deserializer for request/response objects used in tests only
225225
*/
226-
private class TestRuntimeExceptionObjectSerializer extends ObjectSerializer implements CapaObjectSerializer {
226+
private class TestRuntimeExceptionObjectSerializer extends ExtensionObjectSerializer implements CapaObjectSerializer {
227227

228228
/**
229229
* {@inheritDoc}
@@ -254,7 +254,7 @@ public String getContentType() {
254254
/**
255255
* serializer/deserializer for request/response objects used in tests only
256256
*/
257-
private class TestIOExceptionObjectSerializer extends ObjectSerializer implements CapaObjectSerializer {
257+
private class TestIOExceptionObjectSerializer extends ExtensionObjectSerializer implements CapaObjectSerializer {
258258

259259
/**
260260
* {@inheritDoc}

sdk-springboot/src/main/java/group/rxcloud/capa/springboot/pubsub/PubSubBeanPostProcessor.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@
1919
import com.kevinten.vrml.core.beans.SpringContextConfigurator;
2020
import com.kevinten.vrml.core.serialization.Serialization;
2121
import group.rxcloud.capa.infrastructure.exceptions.CapaException;
22+
import group.rxcloud.capa.infrastructure.serializer.CapaObjectSerializer;
2223
import group.rxcloud.capa.infrastructure.serializer.DefaultObjectSerializer;
23-
import group.rxcloud.capa.infrastructure.serializer.ObjectSerializer;
2424
import group.rxcloud.capa.pubsub.Topic;
2525
import group.rxcloud.capa.pubsub.domain.TopicEventRequest;
2626
import group.rxcloud.capa.pubsub.domain.TopicSubscription;
27+
import group.rxcloud.cloudruntimes.utils.TypeRef;
2728
import org.slf4j.Logger;
2829
import org.slf4j.LoggerFactory;
2930
import org.springframework.beans.BeansException;
@@ -49,7 +50,7 @@ public class PubSubBeanPostProcessor implements BeanPostProcessor {
4950
private static final Logger logger = LoggerFactory.getLogger(PubSubBeanPostProcessor.class);
5051

5152
private final EmbeddedValueResolver embeddedValueResolver;
52-
private final ObjectSerializer serializer;
53+
private final CapaObjectSerializer serializer;
5354

5455
PubSubBeanPostProcessor(ConfigurableBeanFactory beanFactory) {
5556
embeddedValueResolver = new EmbeddedValueResolver(beanFactory);
@@ -84,7 +85,7 @@ public Object postProcessAfterInitialization(Object bean, String beanName) throw
8485
* @param clazz Controller class where {@link Topic} is expected.
8586
* @param serializer json serializer
8687
*/
87-
private static void subscribeToTopics(Class clazz, EmbeddedValueResolver embeddedValueResolver, ObjectSerializer serializer) {
88+
private static void subscribeToTopics(Class clazz, EmbeddedValueResolver embeddedValueResolver, CapaObjectSerializer serializer) {
8889
if (clazz == null) {
8990
return;
9091
}
@@ -152,12 +153,12 @@ private static void subscribeToTopics(Class clazz, EmbeddedValueResolver embedde
152153
}
153154
}
154155

155-
private static Map<String, String> resolveMetadataMap(ObjectSerializer serializer, String metadata) {
156+
private static Map<String, String> resolveMetadataMap(CapaObjectSerializer serializer, String metadata) {
156157
Map<String, String> metadataMap = Collections.emptyMap();
157158
if (!StringUtils.isEmpty(metadata)) {
158159
byte[] metadataBytes = metadata.getBytes(StandardCharsets.UTF_8);
159160
try {
160-
metadataMap = serializer.deserialize(metadataBytes, Map.class);
161+
metadataMap = serializer.deserialize(metadataBytes, TypeRef.get(Map.class));
161162
} catch (Exception e) {
162163
if (logger.isErrorEnabled()) {
163164
logger.error("[[email protected]] illegal metadata[{}]",

0 commit comments

Comments
 (0)