fix(ios): Disconnect from peripheral if service discovery fails during connect #803

If service discovery fails, the connection reports an error but surprisingly
remains connected by iOS and the plugin.

Bring this behaviour into alignment with Android by disconnecting if the
connect (including service discovery) fails.

- Log additional information related to service/characteristic discovery
- Upgrade package-lock to node v24

Author: peitschie

ios/Sources/BluetoothLe/Device.swift

@@ -62,7 +62,7 @@ class Device: NSObject, CBPeripheralDelegate {
         _ peripheral: CBPeripheral,
         didDiscoverServices error: Error?
     ) {
-        log("didDiscoverServices")
+        log("didDiscoverServices", peripheral.services?.count ?? -1)
         if let error = error {
             log("Error", error.localizedDescription)
             return
@@ -81,10 +81,21 @@ class Device: NSObject, CBPeripheralDelegate {
         didDiscoverCharacteristicsFor service: CBService,
         error: Error?
     ) {
+        if let error = error {
+            log("didDiscoverCharacteristicsFor",
+                self.servicesDiscovered, self.servicesCount,
+                self.characteristicsDiscovered, self.characteristicsCount)
+            log("Error", error.localizedDescription)
+            return
+        }
+        
         self.servicesDiscovered += 1
-        log("didDiscoverCharacteristicsFor", self.servicesDiscovered, self.servicesCount)
         self.characteristicsCount += service.characteristics?.count ?? 0
 
+        log("didDiscoverCharacteristicsFor",
+            self.servicesDiscovered, self.servicesCount,
+            self.characteristicsDiscovered, self.characteristicsCount)
+
         if !self.skipDescriptorDiscovery {
             for characteristic in service.characteristics ?? [] {
                 peripheral.discoverDescriptors(for: characteristic)

ios/Sources/BluetoothLe/DeviceManager.swift

@@ -313,6 +313,15 @@ class DeviceManager: NSObject, CBCentralManagerDelegate {
         let key = "onDisconnected|\(device.getId())"
         self.callbackMap[key] = callback
     }
+    
+    func cancelConnect(
+        _ device: Device
+    ) {
+        // do not call onDisconnnected, which is triggered by cancelPeripheralConnection
+        let onDisconnectedKey = "onDisconnected|\(device.getId())"
+        self.callbackMap[onDisconnectedKey] = nil
+        self.centralManager.cancelPeripheralConnection(device.getPeripheral())
+    }
 
     func disconnect(
         _ device: Device,
@@ -397,10 +406,7 @@ class DeviceManager: NSObject, CBCentralManagerDelegate {
         _ connectionTimeout: Double
     ) {
         let workItem = DispatchWorkItem {
-            // do not call onDisconnnected, which is triggered by cancelPeripheralConnection
-            let onDisconnectedKey = "onDisconnected|\(device.getId())"
-            self.callbackMap[onDisconnectedKey] = nil
-            self.centralManager.cancelPeripheralConnection(device.getPeripheral())
+            self.cancelConnect(device)
             self.reject(connectionKey, message)
         }
         self.timeoutMap[connectionKey] = workItem

ios/Sources/BluetoothLe/Plugin.swift

@@ -285,6 +285,7 @@ public class BluetoothLe: CAPPlugin, CAPBridgedPlugin {
                 // only resolve after service discovery
                 call.resolve()
             } else {
+                self.deviceManager?.cancelConnect(device)
                 call.reject(message)
             }
         })