Unable to set userId to null

[ramoncarreras]

Describe the bug
setUserId method does not accept null.

https://github.com/capacitor-community/firebase-analytics/blob/master/src/web.ts#L83

To Reproduce

   FirebaseAnalytics.setUserId({
       userId: null,
   });

Expected behavior
When the user logs out, it must be possible to assign null value to it.

See here: https://firebase.google.com/docs/reference/android/com/google/firebase/analytics/FirebaseAnalytics#public-void-setuserid-string-id

[markxoe]

What is the exact Error message?

[ramoncarreras]

The exact error message is: "userId property is missing":

[markxoe]

Could you try undefined? This should work, as it is the default value
See https://github.com/capacitor-community/firebase-analytics/blob/master/src/web.ts#L80

[ramoncarreras]

As long as the condition is !userId, the result will be the same using null or undefined.

See this test on Chrome's console:

IMHO the condition must be:
if (userId === undefined)

[markxoe]

I could make a patch...
I may be doing this later this day

[ramoncarreras]

Thank you very much @markxoe

[markxoe]

I'm just thinking about whether that is possible with the web version; In the docs there is nothing of userId = undefined: https://firebase.google.com/docs/reference/js/firebase.analytics.Analytics#setuserid

And the type of the parameter is string, which is not assignable to undefined

[ramoncarreras]

I have been doing some tests and, in web version, you can pass null to setUserId method and it works properly.
I have tried it with undefined as well, and in this case it is not working.

So, IMHO, you must change L82 this way:

BEFORE
if (!userId) {

AFTER
if (userId === undefined) {

My test screenshot (using setUserId(null);):

[markxoe]

Isn't the user_id=null just the same as user_id="" ? This would be a more elegant solution IMHO

[ramoncarreras]

I think userId="" may work... But:

my proposal was NULL because in the Android and iOS documentation says:

The user ID to ascribe to the user of this app on this device, which must be non-empty and no more than 256 characters long. Setting the ID to null removes the user ID.

See here and here.

[markxoe]

Okay, i think i have the perfect idea, i'm just gonna do it and propose my changes in a Pull-Request

[ramoncarreras]

Okay, i think i have the perfect idea, i'm just gonna do it and propose my changes in a Pull-Request

Thank you.

[markxoe]

See #50