Skip to content

Comments

Add support for addListener on iOS#144

Closed
Sharcoux wants to merge 2 commits intocapacitor-community:masterfrom
cantoo-scribe:master
Closed

Add support for addListener on iOS#144
Sharcoux wants to merge 2 commits intocapacitor-community:masterfrom
cantoo-scribe:master

Conversation

@Sharcoux
Copy link

@Sharcoux Sharcoux commented Mar 11, 2025

We released on @cantoo/text-to-speech if you want to test it. That release is based on version 5.1, though, while this PR is on top of master (v6)

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.

@robingenz
Copy link
Member

I am closing this PR because the changes cannot be merged and no issue is linked.

@robingenz robingenz closed this Oct 24, 2025
@Sharcoux
Copy link
Author

My bad, the PR is wrong indeed. I'll fix it. However, it really fixes a problem:

#140 (for iOS) and #132 (for iOS)

Basically, this makes onRangeStart work for iOS

This was referenced Oct 24, 2025
@Sharcoux
Copy link
Author

I merged the wrong branch (twice). I'll just open a new MR explaining the issue better and with the correct branch as a source so you don't get the code from Cantoo fork, but just what needs to be updated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants