Skip to content

Commit 3dabaac

Browse files
committed
[messages] log exception stacktrace in sendSMS
1 parent 6ec03ed commit 3dabaac

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

app/src/main/java/me/capcom/smsgateway/modules/messages/MessagesService.kt

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ import me.capcom.smsgateway.modules.encryption.EncryptionService
2525
import me.capcom.smsgateway.modules.events.EventBus
2626
import me.capcom.smsgateway.modules.health.domain.CheckResult
2727
import me.capcom.smsgateway.modules.health.domain.Status
28+
import me.capcom.smsgateway.modules.logs.LogsService
29+
import me.capcom.smsgateway.modules.logs.db.LogEntry
2830
import me.capcom.smsgateway.modules.messages.data.SendRequest
2931
import me.capcom.smsgateway.modules.messages.events.MessageStateChangedEvent
3032
import me.capcom.smsgateway.modules.messages.workers.LogTruncateWorker
@@ -38,6 +40,7 @@ class MessagesService(
3840
private val dao: MessagesDao, // todo: use MessagesRepository
3941
private val encryptionService: EncryptionService,
4042
private val events: EventBus,
43+
private val logsService: LogsService,
4144
) {
4245

4346
private val countryCode: String? =
@@ -337,12 +340,20 @@ class MessagesService(
337340

338341
updateState(id, sourcePhoneNumber, ProcessingState.Processed)
339342
} catch (th: Throwable) {
340-
th.printStackTrace()
343+
logsService.insert(
344+
LogEntry.Priority.ERROR,
345+
MODULE_NAME,
346+
"Can't send message: " + th.message,
347+
mapOf(
348+
"stacktrace" to th.stackTraceToString(),
349+
)
350+
)
351+
341352
updateState(
342353
id,
343354
sourcePhoneNumber,
344355
ProcessingState.Failed,
345-
"Sending: " + th.message
356+
"sendSMS: " + th.message
346357
)
347358
}
348359
}

app/src/main/java/me/capcom/smsgateway/modules/messages/Module.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,6 @@ val messagesModule = module {
1212
singleOf(::MessagesService)
1313
viewModel { MessagesListViewModel(get()) }
1414
viewModel { MessageDetailsViewModel(get()) }
15-
}
15+
}
16+
17+
val MODULE_NAME = "messages"

0 commit comments

Comments
 (0)