Really big SMS crashes the app

[benkaiser]

Describe the Bug
I'm trying to test the limits of the service I'm building, but it seems when I send a 4000 word text (~50 texts long) the SMS gateway app crashes.

To Reproduce
Steps to reproduce the behavior:

1. Run the local server + switch it to online
2. Register a webhook subscription
3. Send an SMS to the phone that is ~50 texts(160 chars) long
4. Notice that when the phone finally receives the text, it crashes the relay app
   Expected vs Actual Behavior

• Expected: Relay continues to work and calls my webhook endpoint with the really long text
• Actual: App crashes

Environment

• App Version: latest release build with local loopback fixes
• Mode: Local
• Operation: Receiving SMS
• Integration: Integrating with local node.js server running in termux app
• Network Type: Both wifi and mobile data

Smartphone

• Device: zenfone 8 flip
• OS: Android 13
• SIM Card Count: 1

Additional Context

Here is the raw text of the message I used, it is just a lorem ipsum type generated text.
test.txt

Checklist Before Submission

• I have described the bug in detail.
• I have provided the steps to reproduce.
• I have included screenshots (if applicable).
• I have provided environment details.
• I have included relevant log file excerpts (if applicable).
• I have read FAQ and other relevant information.

[benkaiser]

I found the exception, looks like there is a limit on the size somewhere:

03-14 11:50:22.725  4424  4424 I ActivityThread: ComponentInfo{me.capcom.smsgateway/me.capcom.smsgateway.modules.receiver.MessagesReceiver} onReceive failed
03-14 11:50:22.726  4424  4424 E AndroidRuntime: Process: me.capcom.smsgateway, PID: 4424
03-14 11:50:22.726  4424  4424 E AndroidRuntime: java.lang.RuntimeException: Unable to start receiver me.capcom.smsgateway.modules.receiver.MessagesReceiver: java.lang.IllegalStateException: Data cannot occupy more than 10240 bytes when serialized
03-14 11:50:22.726  4424  4424 E AndroidRuntime:        at me.capcom.smsgateway.modules.webhooks.workers.SendWebhookWorker$Companion.start(SendWebhookWorker.kt:222)
03-14 11:50:22.726  4424  4424 E AndroidRuntime:        at me.capcom.smsgateway.modules.webhooks.WebHooksService.emit(WebHooksService.kt:100)
03-14 11:50:22.726  4424  4424 E AndroidRuntime:        at me.capcom.smsgateway.modules.receiver.ReceiverService.process(ReceiverService.kt:63)
03-14 11:50:22.726  4424  4424 E AndroidRuntime:        at me.capcom.smsgateway.modules.receiver.MessagesReceiver.onReceive(MessagesReceiver.kt:25)
03-14 11:50:22.729  1650  4576 W ActivityTaskManager:   Force finishing activity me.capcom.smsgateway/.MainActivity

[capcom6]

Hello!

Thank you for your report!

This is a very interesting use case for SMS—I didn’t expect anyone to send such large messages. Unfortunately, the issue stems from a limitation imposed by Android.

However, I’ve prepared a quick fix. Please try the APK from this pull request and let me know if it resolves the issue. Unfortunately, I’m unable to test it with such a long text on the emulator, as it seems to trim messages to around 1000 characters.

[benkaiser]

Dang looks like it still crashed with that build. Let me get ADB logs again.

[benkaiser]

Still the same exception being thrown:

03-14 13:27:15.008 18414 18414 E AndroidRuntime: java.lang.RuntimeException: Unable to start receiver me.capcom.smsgateway.modules.receiver.MessagesReceive
r: java.lang.IllegalStateException: Data cannot occupy more than 10240 bytes when serialized
03-14 13:27:15.008 18414 18414 E AndroidRuntime:        at me.capcom.smsgateway.modules.webhooks.workers.SendWebhookWorker$Companion.start(SendWebhookWorke
r.kt:222)
03-14 13:27:15.008 18414 18414 E AndroidRuntime:        at me.capcom.smsgateway.modules.webhooks.WebHooksService.emit(WebHooksService.kt:100)
03-14 13:27:15.008 18414 18414 E AndroidRuntime:        at me.capcom.smsgateway.modules.receiver.ReceiverService.process(ReceiverService.kt:63)
03-14 13:27:15.008 18414 18414 E AndroidRuntime:        at me.capcom.smsgateway.modules.receiver.MessagesReceiver.onReceive(MessagesReceiver.kt:25)
03-14 13:27:15.011  1650  4531 W ActivityTaskManager:   Force finishing activity me.capcom.smsgateway/.MainActivity

Is it the actual gson.toJson(data) call that is throwing it maybe? Does it need to be read out/serealized raw or something/

[benkaiser]

Wait hold up, looks like the install of the patch didn't work. I installed it again and it worked!!

[capcom6]

The stack trace appears to be from the previous version because points out to the middle of expression in the patched version.

Could you confirm if the new version is working correctly now?

[benkaiser]

Yes the new version worked! Ship it! 😁