Skip to content

Commit c36a0fb

Browse files
committed
new model test
1 parent 7724d11 commit c36a0fb

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/ai-review.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,14 @@ jobs:
2121
- uses: SAP/ai-assisted-github-actions/pr-review@v3
2222
with:
2323
aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }}
24-
model: anthropic--claude-4-sonnet
24+
model: mistralai--mistral-small-instruct
2525
model-parameters: '{"temperature": 0.1}'
2626
prompt: |
2727
- As an AI bot reviewing documentation pull requests on GitHub, please focus on the following areas to ensure high-quality and effective documentation:
2828
- Use U.S. English spelling and punctuation.
2929
- Check for spelling errors and provide corrections.
3030
- Identify and correct grammatical errors and incorrect punctuation.
3131
- Provide suggestions for improving the clarity and conciseness of the text to make it more understandable. Use the comments to create real suggestions and include all proposals that target the same line into one suggestions. Do not create multiple suggestions for the same line or paragraph.
32-
- Consider the guidelines that can be found in .github/workflows/assets/editor.md and apply them.
3332
- Ensure that the tone is appropriate for technical documentation, maintaining a professional and informative style.
3433
- Verify that the structure of the document is logical and that headings and subheadings are used effectively.
3534
- Check for consistency in terminology and style throughout the document.

guides/databases/cdl-to-ddl.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Databases are deployed based on the entity definitions in your CDS models. This
1515

1616
CDS compilation to database-specific DDLs is handled by the `cds compile` command, which is part of the [`cds` CLI](../../tools/cds-cli). When you run `cds deploy` or `cds watch`, this command is invoked automatically to generate the necessary DDL statements for your target database.
1717

18-
You can also run the command manually to see the generated DDL for your models. For example, to inspect what the SQL DDL for your entire model would look like, simply run:
18+
You can also run the command manually to view the generated DDL for your models. For example, to inspect what the SQL DDL for your entire model would look like, simply run:
1919

2020
```shell
2121
cds compile \* --to sql
@@ -41,7 +41,7 @@ cds compile \* | grep entity | wc -l
4141

4242
### Database-Specific Dialects
4343

44-
Add the `--dialect` option to generate DDL for specific databases. For example, to see the SAP HANA-specific variant, run:
44+
Add the `--dialect` option to generate DDL for specific databases. For example, to view the SAP HANA-specific variant, run:
4545

4646
```shell
4747
cds compile \* --to sql --dialect hana
@@ -58,7 +58,7 @@ code --diff _out/c/sqlite.sql _out/c/h2.sql
5858
```
5959

6060
> [!tip] CDS models are database-agnostic
61-
> CDS models are designed to be database-agnostic, allowing you to switch between different databases with minimal changes. The `--dialect` option helps you see how your models translate to different database-specific DDLs. \
61+
> CDS models are designed to be database-agnostic, allowing you to switch between different databases with minimal changes. The `--dialect` option shows how your models translate to different database-specific DDLs. \
6262
6363

6464
### Dialects by `cds env` Profiles
@@ -676,7 +676,7 @@ When using `@cds.persistence.exists` for ...
676676
- User-defined functions (UDFs), annotate it with `@cds.persistence.udf` in addition.
677677
- Calculation views, annotate it with `@cds.persistence.calcview` in addition.
678678

679-
See [Calculated Views and User-Defined Functions](./hana-native#calculated-views-and-user-defined-functions) for more details.
679+
Refer to [Calculated Views and User-Defined Functions](./hana-native#calculated-views-and-user-defined-functions) for more details.
680680
:::
681681

682682

@@ -736,7 +736,7 @@ CREATE VIEW ListOfBooks AS SELECT ... FROM Books WITH DDL ONLY;
736736
- `@sql.prepend` is only supported for entities translating to tables. It can't be used with views or with elements.
737737

738738
> [!note] Note for SAP HANA
739-
> Ensure to read [Schema Evolution Support of Native Database Clauses](hana#schema-evolution-native-db-clauses) if you plan to use these annotations in combination with [`@cds.persistence.journal`](hana#enabling-hdbmigrationtable-generation).
739+
> Ensure to review [Schema Evolution Support of Native Database Clauses](hana#schema-evolution-native-db-clauses) if you plan to use these annotations in combination with [`@cds.persistence.journal`](hana#enabling-hdbmigrationtable-generation).
740740
741741
> [!caution]
742742
> The content of these annotations is inserted as-is into the generated DDL statements without any validation or other processing by the compiler. Use this feature with caution, as incorrect SQL clauses may lead to deployment failures or runtime errors. You're responsible to ensure that the resulting statement is valid and doesn't negatively impact your database or your application. **We don't provide support for problems caused by using this feature.**

0 commit comments

Comments
 (0)