Merge pull request #70 from capotej/error_handling

crush: fix error handling

Author: capotej

app/controllers/blog_controller.rb

@@ -53,17 +53,21 @@ def feed_by_tag
   end
 
   def create
-    post = Post.create! post_params
-    redirect_to dated_post_path(year: post.year, month: post.month, day: post.day, id: post.slug)
+    @post = Post.new(post_params)
+    if @post.save
+      redirect_to dated_post_path(year: @post.year, month: @post.month, day: @post.day, id: @post.slug)
+    else
+      render :new, status: :unprocessable_content
+    end
   end
 
   def update
-    post = Post.find_by_slug(params[:id])
-    post.markdown_body_attachments.purge
-    if post.update(post_params)
-      redirect_to dated_post_path(year: post.year, month: post.month, day: post.day, id: post.slug)
+    @post = Post.find_by_slug(params[:id])
+    @post.markdown_body_attachments.purge
+    if @post.update(post_params)
+      redirect_to dated_post_path(year: @post.year, month: @post.month, day: @post.day, id: @post.slug)
     else
-      render :edit, status: :unprocessable_entity
+      render :edit, status: :unprocessable_content
     end
   end
 

app/controllers/feeds_controller.rb

@@ -14,7 +14,7 @@ def create
     if @feed.save
       redirect_to feeds_path, notice: "Feed was successfully created."
     else
-      render :new
+      render :new, status: :unprocessable_content
     end
   end
 
@@ -25,7 +25,7 @@ def update
     if @feed.update(feed_params)
       redirect_to feeds_path, notice: "Feed was successfully updated."
     else
-      render :edit
+      render :edit, status: :unprocessable_content
     end
   end
 

app/controllers/links_controller.rb

@@ -22,16 +22,20 @@ def feed
   end
 
   def create
-    link = Link.create! link_params
-    redirect_to links_path
+    @link = Link.new(link_params)
+    if @link.save
+      redirect_to links_path
+    else
+      render :new, status: :unprocessable_content
+    end
   end
 
   def update
     @link = Link.find(params[:id])
     if @link.update(link_params)
       redirect_to links_path
     else
-      render :edit, status: :unprocessable_entity
+      render :edit, status: :unprocessable_content
     end
   end
 

app/controllers/pages_controller.rb

@@ -19,8 +19,12 @@ def index
   end
 
   def create
-    post = Page.create! page_params
-    redirect_to post
+    @page = Page.new(page_params)
+    if @page.save
+      redirect_to @page
+    else
+      render :new, status: :unprocessable_content
+    end
   end
 
   def update
@@ -29,7 +33,7 @@ def update
     if @page.update(page_params)
       redirect_to @page
     else
-      render :edit, status: :unprocessable_entity
+      render :edit, status: :unprocessable_content
     end
   end
 

app/views/blog/_form.html.erb

@@ -1,8 +1,5 @@
 <%= form_with model: post, class: "space-y-6" do |form| %>
-
-  <% post.errors.each do |error| %>
-    <div><%= error.full_message %></div>
-  <% end %>
+  <%= render "shared/form_errors", object: post %>
 
   <div class="space-y-2">
     <%= form.label :title, class: "block text-sm font-medium text-gray-700 dark:text-gray-200" %>

app/views/feeds/_form.html.erb

@@ -1,7 +1,5 @@
 <%= form_with model: feed, class: "space-y-6" do |form| %>
-  <% feed.errors.each do |error| %>
-    <div><%= error.full_message %></div>
-  <% end %>
+  <%= render "shared/form_errors", object: feed %>
 
   <div class="space-y-2">
     <%= form.label :name, class: "block text-sm font-medium text-gray-700 dark:text-gray-200" %>

app/views/links/_form.html.erb

@@ -1,7 +1,5 @@
 <%= form_with model: link, class: "space-y-6" do |form| %>
-  <% link.errors.each do |error| %>
-    <div><%= error.full_message %></div>
-  <% end %>
+  <%= render "shared/form_errors", object: link %>
 
   <div class="space-y-2">
     <%= form.label :url, class: "block text-sm font-medium text-gray-700 dark:text-gray-200" %>

app/views/pages/_form.html.erb

@@ -1,7 +1,5 @@
 <%= form_with model: page, class: "space-y-6" do |form| %>
-  <% page.errors.each do |error| %>
-    <div><%= error.full_message %></div>
-  <% end %>
+  <%= render "shared/form_errors", object: page %>
 
   <div class="space-y-2">
     <%= form.label :title, class: "block text-sm font-medium text-gray-700 dark:text-gray-200" %>

app/views/shared/_form_errors.html.erb

@@ -0,0 +1,23 @@
+<% if object.errors.any? %>
+  <div class="rounded-lg border border-red-200 bg-red-50 p-4 mb-6 dark:border-red-800 dark:bg-red-950/50 transition-colors">
+    <div class="flex">
+      <div class="flex-shrink-0">
+        <svg class="h-5 w-5 text-red-500 dark:text-red-400" viewBox="0 0 20 20" fill="currentColor" aria-hidden="true">
+          <path fill-rule="evenodd" d="M10 18a8 8 0 100-16 8 8 0 000 16zM8.28 7.22a.75.75 0 00-1.06 1.06L8.94 10l-1.72 1.72a.75.75 0 101.06 1.06L10 11.06l1.72 1.72a.75.75 0 101.06-1.06L11.06 10l1.72-1.72a.75.75 0 00-1.06-1.06L10 8.94 8.28 7.22z" clip-rule="evenodd" />
+        </svg>
+      </div>
+      <div class="ml-3 flex-1">
+        <h3 class="text-sm font-semibold text-red-800 dark:text-red-200">
+          <%= pluralize(object.errors.count, "error") %> prohibited this <%= object.class.model_name.human.downcase %> from being saved
+        </h3>
+        <div class="mt-3 text-sm text-red-700 dark:text-red-300">
+          <ul role="list" class="list-disc space-y-1 pl-5 marker:text-red-400 dark:marker:text-red-500">
+            <% object.errors.each do |error| %>
+              <li class="pl-1"><%= error.full_message %></li>
+            <% end %>
+          </ul>
+        </div>
+      </div>
+    </div>
+  </div>
+<% end %>