fix: irregular code and workflows

Author: capsolver

.github/workflows/publish-npm.yml

@@ -115,7 +115,7 @@ jobs:
           fi
 
       - name: Generate release
-        if: steps.check-commits.outputs.should_release == 'true'
+        if: success() && steps.check-commits.outputs.should_release == 'true'
         run: |
           if [ "${{ steps.check-commits.outputs.version_type }}" == "major" ]; then
             echo "Running major release"
@@ -129,14 +129,14 @@ jobs:
           fi
 
       - name: Push changes and tags
-        if: steps.check-commits.outputs.should_release == 'true'
+        if: success() && steps.check-commits.outputs.should_release == 'true'
         run: |
           git push --follow-tags origin main
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Publish package
-        if: steps.check-commits.outputs.should_release == 'true'
+        if: success() && steps.check-commits.outputs.should_release == 'true'
         run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

nodes/CapSolver/Capsolver.node.ts

@@ -3,13 +3,17 @@ import {
 	INodeExecutionData,
 	INodeType,
 	INodeTypeDescription,
+	NodeConnectionTypes,
 	NodeOperationError,
 } from 'n8n-workflow';
 import { INodeContext, Solver } from './libs';
 import { handleRecognitionActions, handleTokenActions } from './actions';
 import { captchaTypes, resourceRecognition, resourceToken } from './config';
 import { optionalDescriptions, recognitionDescriptions, tokenDescriptions } from './descriptions';
 
+const inputs = [NodeConnectionTypes.Main];
+const outputs = [NodeConnectionTypes.Main];
+
 export class CapSolver implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'CapSolver',
@@ -22,8 +26,8 @@ export class CapSolver implements INodeType {
 		defaults: {
 			name: 'CapSolver',
 		},
-		inputs: ['main'],
-		outputs: ['main'],
+		inputs,
+		outputs,
 		credentials: [
 			{
 				name: 'capSolverApi',
@@ -52,7 +56,7 @@ export class CapSolver implements INodeType {
 
 			// operation token
 			{
-				displayName: 'Captcha',
+				displayName: 'Operation',
 				name: 'operation',
 				type: 'options',
 				default: captchaTypes.recaptchaV2,

nodes/CapSolver/actions/recognitionActions.ts

@@ -56,7 +56,7 @@ export async function handleRecognitionActions(context: INodeContext): Promise<I
 				success: true,
 				data: result,
 			},
-			pairedItem: context.i,
+			pairedItem: { item: context.i },
 		};
 	} catch (error) {
 		if (context.functionThis.continueOnFail()) {

nodes/CapSolver/actions/tokenActions.ts

@@ -39,7 +39,7 @@ export async function handleTokenActions(context: INodeContext): Promise<INodeEx
 				success: true,
 				data: result,
 			},
-			pairedItem: context.i,
+			pairedItem: { item: context.i },
 		};
 	} catch (error) {
 		if (context.functionThis.continueOnFail()) {

nodes/CapSolver/libs/solver.ts

@@ -1,4 +1,4 @@
-import { IExecuteFunctions, NodeOperationError } from 'n8n-workflow';
+import { IExecuteFunctions, NodeOperationError, sleep } from 'n8n-workflow';
 import { Task } from './task';
 import { resourceRecognition, TIME_OUT } from '../config';
 
@@ -43,13 +43,7 @@ export class Solver {
 					`Get task result timeout: unable to solve within ${TIME_OUT} seconds`,
 				);
 			}
-			this.delay(1000);
+			await sleep(1000);
 		}
 	}
-
-	private delay(ms: number): void {
-		const sab = new SharedArrayBuffer(4);
-		const arr = new Int32Array(sab);
-		Atomics.wait(arr, 0, 0, ms);
-	}
 }