fix(M68K): fix cross-arch bugs in cpush/cinv and dc.w printing

build_cpush_cinv: use op1->reg instead of op1->imm for address
register operand. Writing to imm (uint64_t) when reg (m68k_reg,
uint32_t) is read back causes garbage values on big-endian targets
(PPC64, s390x) due to union byte order mismatch.

M68K_printInst: cast imm to uint32_t before passing to PRIx32
format. Passing uint64_t to a PRIx32 format specifier is UB; on
32-bit big-endian MIPS the high word (0) is read instead of the
low word containing the instruction bytes.

Fixes cstest details failures on QEMU Linux PPC64, s390x, Mips32.

Author: b1llow

arch/M68K/M68KDisassembler.c

@@ -99,7 +99,8 @@
 
 #define M68010_ONLY TYPE_68010
 #define M68010_LESS (TYPE_68000 | TYPE_68010)
-#define M68010_PLUS (TYPE_68010 | TYPE_68020 | TYPE_68030 | TYPE_68040 | TYPE_68060)
+#define M68010_PLUS \
+	(TYPE_68010 | TYPE_68020 | TYPE_68030 | TYPE_68040 | TYPE_68060)
 
 #define M68020_ONLY TYPE_68020
 #define M68020_LESS (TYPE_68010 | TYPE_68020)
@@ -1246,7 +1247,7 @@ static void build_cpush_cinv(m68k_info *info, int op_offset)
 
 	op1->type = M68K_OP_MEM;
 	op1->address_mode = M68K_AM_REG_DIRECT_ADDR;
-	op1->imm = M68K_REG_A0 + (info->ir & 7);
+	op1->reg = M68K_REG_A0 + (info->ir & 7);
 }
 
 static void build_movep_re(m68k_info *info, int size)
@@ -3600,10 +3601,18 @@ static void d68cpu32_tbl(m68k_info *info)
 	size_bits = (ext_word >> 6) & 3;
 
 	switch (size_bits) {
-	case 0: size = 1; break; /* byte */
-	case 1: size = 2; break; /* word */
-	case 2: size = 4; break; /* long */
-	default: d68000_invalid(info); return;
+	case 0:
+		size = 1;
+		break; /* byte */
+	case 1:
+		size = 2;
+		break; /* word */
+	case 2:
+		size = 4;
+		break; /* long */
+	default:
+		d68000_invalid(info);
+		return;
 	}
 
 	if (is_signed && is_round)
@@ -3680,7 +3689,8 @@ static void d68030_pmmu(m68k_info *info)
 			/* PFLUSH #fc, #mask, (ea) */
 			int mask = (cmd >> 5) & 7;
 			int fc = cmd & 0x1f;
-			cs_m68k *ext = build_init_op(info, M68K_INS_PFLUSH, 3, 0);
+			cs_m68k *ext =
+				build_init_op(info, M68K_INS_PFLUSH, 3, 0);
 			cs_m68k_op *op0 = &ext->operands[0];
 			cs_m68k_op *op1 = &ext->operands[1];
 			cs_m68k_op *op2 = &ext->operands[2];
@@ -3751,9 +3761,15 @@ static void d68030_pmmu(m68k_info *info)
 		cs_m68k_op *op1;
 
 		switch (preg) {
-		case 0: pmmu_reg = M68K_REG_TC; break;
-		case 2: pmmu_reg = M68K_REG_SRP; break;
-		case 3: pmmu_reg = M68K_REG_CRP; break;
+		case 0:
+			pmmu_reg = M68K_REG_TC;
+			break;
+		case 2:
+			pmmu_reg = M68K_REG_SRP;
+			break;
+		case 3:
+			pmmu_reg = M68K_REG_CRP;
+			break;
 		default:
 			d68000_invalid(info);
 			return;
@@ -3864,8 +3880,12 @@ static void d68030_pmmu(m68k_info *info)
 		cs_m68k_op *op1;
 
 		switch (preg) {
-		case 2: pmmu_reg = M68K_REG_TT0; break;
-		case 3: pmmu_reg = M68K_REG_TT1; break;
+		case 2:
+			pmmu_reg = M68K_REG_TT0;
+			break;
+		case 3:
+			pmmu_reg = M68K_REG_TT1;
+			break;
 		default:
 			d68000_invalid(info);
 			return;

arch/M68K/M68KInstPrinter.c

@@ -383,7 +383,7 @@ void M68K_printInst(MCInst *MI, SStream *O, void *PrinterInfo)
 	if (MI->Opcode == M68K_INS_INVALID) {
 		if (ext->op_count)
 			SStream_concat(O, "dc.w $%" PRIx32,
-				       ext->operands[0].imm);
+				       (uint32_t)ext->operands[0].imm);
 		else
 			SStream_concat(O, "dc.w $<unknown>");
 		return;