Backing down on being opinionated

Since Jetbrains IDEs are currently not working with docker --tty
I removed forcing the TTY. You will have to add in manually if
you need it.

Author: sebastianfeldmann

src/Hook/Template/Docker.php

@@ -113,10 +113,14 @@ private function getOptimizeDockerCommand(string $hook): string
             $endExec    = $position + 11;
             $executable = substr($command, 0, $endExec);
             $options    = substr($command, $endExec);
-            $tty        = Hooks::allowsUserInput($hook) ? ' -t' : '';
 
+            // Because this currently breaks working with Jetbrains IDEs I will deactivate it for now
+            //
+            // $tty        = Hooks::allowsUserInput($hook) ? ' -t' : '';
+            // $useTTY      = !preg_match('# -[a-z]*t| --tty#', $options) ? $tty : '';
+
+            $useTTY      = '';
             $interactive = !preg_match('# -[a-z]*i| --interactive#', $options) ? ' -i' : '';
-            $useTTY      = !preg_match('# -[a-z]*t| --tty#', $options) ? $tty : '';
             $env         = !preg_match('# (-[a-z]*e|--env)[= ]+GIT_INDEX_FILE#', $options) ? ' -e GIT_INDEX_FILE' : '';
             $command     = trim($executable) . $interactive . $useTTY . $env . ' ' . trim($options);
         }

tests/unit/Hook/Template/DockerTest.php

@@ -117,15 +117,15 @@ public function testDockerCommandOptimization(string $exec, string $expected, st
     public function replacementPossibilities(): array
     {
         return [
-            ['cap-container', '-i -t -e GIT_INDEX_FILE cap-container', 'none'],
+            ['cap-container', '-i -e GIT_INDEX_FILE cap-container', 'none'],
             ['-it cap-container', '-e GIT_INDEX_FILE -it cap-container', '-it'],
             ['-ti cap-container', '-e GIT_INDEX_FILE -ti cap-container', '-ti'],
             ['--interactive --tty cap-container', '-e GIT_INDEX_FILE --interactive --tty cap-container', 'long it'],
             ['--tty --interactive cap-container', '-e GIT_INDEX_FILE --tty --interactive cap-container', 'long ti'],
             ['--tty cap-container', '-i -e GIT_INDEX_FILE --tty cap-container', 'no i'],
             ['-xit cap-container', '-e GIT_INDEX_FILE -xit cap-container', 'prefixed i'],
             ['-xite=GIT_INDEX_FILE cap-container', '-xite=GIT_INDEX_FILE cap-container', 'prefixed e'],
-            ['--env=GIT_INDEX_FILE cap-container', '-i -t --env=GIT_INDEX_FILE cap-container', 'long e'],
+            ['--env=GIT_INDEX_FILE cap-container', '-i --env=GIT_INDEX_FILE cap-container', 'long e'],
         ];
     }
 }