Skip to content

Commit 28c36e5

Browse files
committed
Ensure builds happen early enough in CI
1 parent 99e4ae4 commit 28c36e5

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

.github/workflows/ci.yml

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,13 @@ jobs:
100100
path: |
101101
packages/ani-cursor/dist
102102
packages/winamp-eqf/built
103-
packages/webamp/built/*.js
104-
packages/webamp/built/*.mjs
105-
packages/webamp/built/*.map
106-
packages/webamp/built/*.html
103+
packages/webamp/built
107104
key: library-artifacts-${{ github.sha }}
108105

109-
# Lint job - runs in parallel
106+
# Lint job - depends on build-library for type declarations
110107
lint:
111108
runs-on: ubuntu-latest
112-
needs: setup
109+
needs: [setup, build-library]
113110
steps:
114111
- uses: actions/checkout@v4
115112
- name: Install pnpm
@@ -123,20 +120,24 @@ jobs:
123120
cache: "pnpm"
124121
- name: Install Dependencies
125122
run: pnpm install --frozen-lockfile
126-
- name: Build Dependencies
127-
run: |
128-
# Build ani-cursor and winamp-eqf first so their types are available
129-
pnpm --filter ani-cursor build
130-
pnpm --filter winamp-eqf build
123+
- name: Restore library artifacts
124+
uses: actions/cache@v4
125+
with:
126+
path: |
127+
packages/ani-cursor/dist
128+
packages/winamp-eqf/built
129+
packages/webamp/built
130+
key: library-artifacts-${{ github.sha }}
131+
fail-on-cache-miss: true
131132
- name: Lint
132133
run: |
133134
pnpm lint
134135
pnpm type-check
135136
136-
# Test job - runs in parallel
137+
# Test job - waits for build artifacts
137138
test:
138139
runs-on: ubuntu-latest
139-
needs: setup
140+
needs: [setup, build]
140141
steps:
141142
- uses: actions/checkout@v4
142143
- name: Install pnpm
@@ -221,10 +222,7 @@ jobs:
221222
path: |
222223
packages/ani-cursor/dist
223224
packages/winamp-eqf/built
224-
packages/webamp/built/*.js
225-
packages/webamp/built/*.mjs
226-
packages/webamp/built/*.map
227-
packages/webamp/built/*.html
225+
packages/webamp/built
228226
key: library-artifacts-${{ github.sha }}
229227
fail-on-cache-miss: true
230228
- name: Set version for all packages

0 commit comments

Comments
 (0)