Skip to content

Commit b666670

Browse files
committed
Fix types for metadata
1 parent e043a1b commit b666670

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

packages/webamp/js/fileUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import invariant from "invariant";
2-
import { IMusicMetadataApi, IMusicMetadataBrowserApi } from "./types";
2+
import { IMetadataApi } from "./types";
33
import { IAudioMetadata } from "music-metadata-browser"; // Import music-metadata type definitions
44
import * as Utils from "./utils";
55

66
type MediaDataType = string | ArrayBuffer | Blob;
77

88
export async function genMediaTags(
99
file: MediaDataType,
10-
musicMetadata: IMusicMetadataBrowserApi | IMusicMetadataApi
10+
musicMetadata: IMetadataApi
1111
): Promise<IAudioMetadata> {
1212
invariant(
1313
file != null,

packages/webamp/js/types.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,9 +893,11 @@ export interface IMusicMetadataApi {
893893
parseBlob(blob: Blob, options?: IOptions): Promise<IAudioMetadata>;
894894
}
895895

896+
export type IMetadataApi = IMusicMetadataBrowserApi | IMusicMetadataApi;
897+
896898
export interface Extras {
897899
requireJSZip(): Promise<any>;
898-
requireMusicMetadata(): Promise<IMusicMetadataBrowserApi>;
900+
requireMusicMetadata(): Promise<IMetadataApi>;
899901
convertPreset: ((file: File) => Promise<Object>) | null;
900902
handleTrackDropEvent?: (
901903
e: React.DragEvent<HTMLDivElement>

packages/webamp/js/webampLazy.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
MediaStatus,
1515
PlaylistTrack,
1616
PlayerMediaStatus,
17+
IMetadataApi,
1718
} from "./types";
1819
import getStore from "./store";
1920
import App from "./components/App";
@@ -52,7 +53,7 @@ export interface PrivateOptions {
5253

5354
export interface InjectableDependencies {
5455
requireJSZip: () => Promise<typeof import("jszip")>;
55-
requireMusicMetadata: () => Promise<typeof import("music-metadata")>;
56+
requireMusicMetadata: () => Promise<IMetadataApi>;
5657
}
5758

5859
class Webamp {

0 commit comments

Comments
 (0)